Reader for Mosaic files #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build is broken. Frictionless moved to >= 1.0 versions of their packages and renamed |
Ensure datapackage<1.0
|
@gsergeant could you please investigate why the build is failing? Please, assume the dependency is for |
…into mosaic_reader
|
Ensuring the Excuse the seemingly extra re-commits, I essentially just rebased the branch. |
|
Brilliant! I see that you added some documentation/examples, which is great. Have you also got some tests (sorry if I missed them)? |
|
That I forgot, but will add it now. |
agbeltran
approved these changes
Jan 31, 2018
This was referenced Mar 20, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a reader for the Mosaic tracking plugin, as per issue #36 .
These files can be saved in multiple extension formats (csv, tsv, txt -- uses ImageJ Results tables), so I've changed the delegator for these cases.
With pandas, the engine now auto-determines the separator and creates the correct reader class according to the first term in the header. This partially addresses #16 for now, at least for these three extensions.
Also fixes the minor indentation bug for #40