Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Visualizer configurability? #210

Open
JCash opened this issue May 31, 2022 · 2 comments
Open

Q: Visualizer configurability? #210

JCash opened this issue May 31, 2022 · 2 comments

Comments

@JCash
Copy link
Contributor

JCash commented May 31, 2022

Regarding the visualizer, I'm thinking about ideas on how to specify the initial view.
Each time I connect the engine+visualizer, I get the threads list populated.
The Remotery thread shows up first, then threads in "random" order.
I'd like to be able to sort the list (putting my main thread first, and Remotery last), giving a better default view for our users.

Such settings could be done using the properties url (like the addr property).
E.g. url?sort=main,sound,Remotery

Thinking more about it, another idea is to be able to save settings from the visualizer into a cookie or something. This could be presented via a dropdown list.
It would further minimize the effort in continuing where the last debug session left off.
(e.g. expanding the flame graph of the threads to the desired depth)

Have you had any thoughts around this?

@dwilliamson
Copy link
Collaborator

We have the start of a Settings object here:

Settings = (function()
{
function Settings()
{
this.IsPaused = false;
this.SyncTimelines = true;
}
return Settings;

This should be stored in LocalStore but right now it's not. All we store there is the last connection address you used, so that will always be preserved between sessions. The goals are:

  • Put Remotery.ConnectionAddress into Settings.
  • Save the Settings object in LocalStore.
  • Provide import and export for the Settings object so you can share them with developers.
  • Settings import can be done by dragging the settings file onto the viewer, just like we already do for recorded traces.

I have written some code that sorts the timeline rows by name which I will commit later today after my client responsibilities have been done. In most cases Remotery actually ends up in near the end due to the letter R. This behaviour could be made into an option to sort up/down or not.

We could also add draggable timeline rows so you can sort the order yourself, but that's more involved.

@dwilliamson
Copy link
Collaborator

Sorting has gone in here 6cea510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants