From 81745f592307df4d05150d458b44166968ad9137 Mon Sep 17 00:00:00 2001 From: Maksim Ramanenkau Date: Tue, 7 May 2024 18:39:06 +0400 Subject: [PATCH] Feature/extend pr template (#329) ### Description ### Types of Changes - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. --- .github/auto_assign.yml | 3 +-- .github/pull_request_template.md | 40 +++++++++++++++++++++++++++++--- 2 files changed, 38 insertions(+), 5 deletions(-) diff --git a/.github/auto_assign.yml b/.github/auto_assign.yml index d04ca19a2..a39f5703c 100644 --- a/.github/auto_assign.yml +++ b/.github/auto_assign.yml @@ -1,11 +1,10 @@ addReviewers: true addAssignees: author reviewers: - - rakanalh - MRamanenkau - - Raid5594 - aie0 - yahortsaryk + - ayushmishra2005 skipKeywords: - wip numberOfReviewers: 1 diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0c19d98be..08191dd51 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,16 @@ -### Description +## Description +## Types of Changes +Please select the branch type you are merging and fill in the relevant template. + +- [ ] Hotfix +- [ ] Release +- [ ] Fix or Feature + +## Fix or Feature + + ### Types of Changes - [ ] Tech Debt (Code improvements) @@ -15,8 +25,32 @@ - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` -### Checklist +### Checklist for Fix or Feature - [ ] Change has been tested locally. -- [ ] Change adds / updates tests. +- [ ] Change adds / updates tests if applicable. - [ ] Changelog doc updated. + +## Checklist for Hotfix + +- [ ] Change has been deployed to Testnet. +- [ ] Change has been tested in Testnet. +- [ ] Changelog has been updated. +- [ ] Crate version has been updated. +- [ ] Spec version has been updated. +- [ ] Transaction version has been updated if required. +- [ ] Pull Request to `dev` has been created. +- [ ] Pull Request to `staging` has been created. + +## Checklist for Release + +- [ ] Change has been deployed to Devnet. +- [ ] Change has been tested in Devnet. +- [ ] Change has been deployed to Qanet. +- [ ] Change has been tested in Qanet. +- [ ] Change has been deployed to Testnet. +- [ ] Change has been tested in Testnet. +- [ ] Changelog has been updated. +- [ ] Crate version has been updated. +- [ ] Spec version has been updated. +- [ ] Transaction version has been updated if required.