From 6dec2361b1d2df0202b23b373a7d292bcfc7c8b1 Mon Sep 17 00:00:00 2001
From: Janine Liu <janine@cesium.com>
Date: Tue, 29 Oct 2024 14:01:10 -0400
Subject: [PATCH] Minor cleanup
---
...e.EXT_implicit_cylinder_region.schema.json | 2 +-
.../EXT_implicit_ellipsoid_region/README.md | 39 ++++++++++++++++++-
....EXT_implicit_ellipsoid_region.schema.json | 2 +-
3 files changed, 40 insertions(+), 3 deletions(-)
diff --git a/extensions/2.0/Vendor/EXT_implicit_cylinder_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_cylinder_region.schema.json b/extensions/2.0/Vendor/EXT_implicit_cylinder_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_cylinder_region.schema.json
index 74a4fdd290..3dd6e0d3d3 100644
--- a/extensions/2.0/Vendor/EXT_implicit_cylinder_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_cylinder_region.schema.json
+++ b/extensions/2.0/Vendor/EXT_implicit_cylinder_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_cylinder_region.schema.json
@@ -3,7 +3,7 @@
"$id": "glTF.KHR_implicit_shapes.shape.EXT_implicit_cylinder_region.schema.json",
"title": "EXT_implicit_cylinder_region extension on KHR_implicit_shapes.shape",
"type": "object",
- "description": "`EXT_implicit_cylinder_region` extension on `KHR_implicit_shapes.shape` to represent an implicit cylinder region in a glTF model.",
+ "description": "Extension of `KHR_implicit_shapes.shape` to represent an implicit cylinder region in a glTF model.",
"allOf": [
{
"$ref": "glTFProperty.schema.json"
diff --git a/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/README.md b/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/README.md
index f362d75ea8..d6eb1ddefb 100644
--- a/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/README.md
+++ b/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/README.md
@@ -24,7 +24,7 @@ The reference ellipsoid is centered at the origin. The `semiMajorAxisRadius` ind
The `semiMinorAxisRadius` indicates the radius of the ellipsoid in meters along the `y` axis.
-The `minHeight` and `maxHeight` properties indicates the heights of the region from the ellipsoid's surface, in meters. The `minimum` height should be lower a value, but not necessarily closer to the surface of the ellipsoid. For example, `maxHeight` may be `10` while `minHeight` is `-100`.
+The `minHeight` and `maxHeight` properties indicates the heights of the region from the ellipsoid's surface, in meters. The `minimum` height should be a lower value, but not necessarily lower in magnitude. For example, `maxHeight` may be `10` while `minHeight` is `-100`.
<table>
<tr>
@@ -60,5 +60,42 @@ The `minHeight` and `maxHeight` properties indicates the heights of the region f
</tr>
</table>
+An ellipsoid region may also be confined to a specific latitude and/or longitude range. The `minLatitude` and `maxLatitude` properties represent the latitude values at which the region starts and stops, defined in the range `[-pi/2, pi/2]`. Similarly, the `minLatitude` and `maxLatitude` properties represent the longitude bounds within the range `[-pi, pi]`.
+
+<table>
+ <tr>
+ <th>
+ Example
+ </th>
+ </tr>
+ <tr>
+ <td><pre>
+ "extensions": [
+ {
+ "KHR_implicit_shapes": {
+ "shapes": [
+ {
+ "type": "ellipsoid region",
+ "extensions": {
+ "EXT_implicit_ellipsoid_region": {
+ "semiMajorAxisRadius": 4,
+ "semiMinorAxisRadius": 2,
+ "minHeight": 0,
+ "maxHeight": 0.5,
+ // TODO
+ }
+ }
+ }
+ ]
+ }
+ }
+ ]
+ </pre></td>
+ <td>
+ **TODO** visual example
+ </td>
+ </tr>
+</table>
+
## Optional vs. Required
This extension is required, meaning it should be placed in both the `extensionsUsed` list and `extensionsRequired` list.
\ No newline at end of file
diff --git a/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_ellipsoid_region.schema.json b/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_ellipsoid_region.schema.json
index c9166b4997..70f023ccd5 100644
--- a/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_ellipsoid_region.schema.json
+++ b/extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/schema/glTF.KHR_implicit_shapes.shape.EXT_implicit_ellipsoid_region.schema.json
@@ -3,7 +3,7 @@
"$id": "glTF.KHR_implicit_shapes.shape.EXT_implicit_ellipsoid_region.schema.json",
"title": "EXT_implicit_ellipsoid_region extension on KHR_implicit_shapes.shape",
"type": "object",
- "description": "`EXT_implicit_ellipsoid_region` extension on `KHR_implicit_shapes.shape` to represent an implicit ellipsoid region in a glTF model. Useful for geospatial applications, such as Earth-conforming voxel data.",
+ "description": "Extension of `KHR_implicit_shapes.shape` to represent an implicit ellipsoid region in a glTF model.",
"allOf": [
{
"$ref": "glTFProperty.schema.json"