Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Whether label_number is Used or Obsolete in ChEBI Dataset Class #47

Open
aditya0by0 opened this issue Aug 27, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation understanding needed Need more explanation/knowledge

Comments

@aditya0by0
Copy link
Collaborator

Description

We need to understand whether the label_number property in the ChEBIOverX class and its derivatives (ChEBIOver100, ChEBIOver50) is actually used anywhere in the dataset creation process or pipeline.

  1. Is label_number referenced or used in any part of the codebase, including dataset creation, processing, or any downstream tasks?

    • If used, what purpose does it serve?
  2. If label_number is not used, can it be considered obsolete, and should it be removed to clean up the codebase?

  3. Assess whether retaining label_number serves any potential future purpose, or if it should be refactored.

Relevant Code

class ChEBIOverX(_ChEBIDataExtractor):
    LABEL_INDEX: int = 3
    SMILES_INDEX: int = 2
    READER: dr.ChemDataReader = dr.ChemDataReader
    THRESHOLD: int = None

    @property
    def label_number(self) -> int:
        return 854

    def select_classes(self, g: nx.Graph, split_name: str, *args, **kwargs) -> List:
        # Implementation...
        return nodes


class ChEBIOver100(ChEBIOverX):
    THRESHOLD: int = 100

    def label_number(self) -> int:
        return 854


class ChEBIOver50(ChEBIOverX):
    THRESHOLD: int = 50

    def label_number(self) -> int:
        return 1332
@aditya0by0 aditya0by0 added understanding needed Need more explanation/knowledge documentation Improvements or additions to documentation labels Aug 27, 2024
@sfluegel05
Copy link
Collaborator

As far as I am aware, this property is obsolete. @MGlauer You probably added it - do you know what the purpose was?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation understanding needed Need more explanation/knowledge
Projects
None yet
Development

No branches or pull requests

2 participants