Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Signature.isInfinity method #73

Open
mpetrunic opened this issue Dec 10, 2020 · 2 comments
Open

Support Signature.isInfinity method #73

mpetrunic opened this issue Dec 10, 2020 · 2 comments

Comments

@mpetrunic
Copy link
Member

I vaguely remember we had that. It's somewhat easy to implement by checking serialized bytes. But it's more user friendly if it's in bls.

@dapplion
Copy link
Contributor

I've had some confusion with that, in herumi's implementation it's called .isZero() while in BLST is_inf(). Would you want to use the name infinity?

@mpetrunic
Copy link
Member Author

Yeah, I think Infinity is suitable. I wonder if it's the same thing.
I also think we shouldn't deserialize signature to check that. We could just have static method to check if signature bytes matches:
https://github.com/ethereum/eth2.0-specs/pull/2141/files#diff-0e2661bd146a3f91f47225e75d80a3234e5ef4a0b451c57d6c34a822b2ee2f86R55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants