feat: chunkify handleFindNode #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Jan 6, 2023
| if (nodes.length === 0) { | ||
| log("Sending empty NODES response to %o", nodeAddr); | ||
| try { | ||
| this.sessionService.sendResponse(nodeAddr, createNodesMessage(id, 1, nodes)); |
There was a problem hiding this comment.
After this PR we no longer send a NODES response if we've found no nodes, is that intended?
There was a problem hiding this comment.
when there is no nodes, the chunkify function returns [[]] (see the unit test), in that case we still send 1 response with total = 1
wemeetagain
force-pushed
the
master
branch
2 times, most recently
from
b3e0a17
to
938e0fb
Compare
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
slice()to make sure the resulting nodes contain 16 items at most, we shouldpush()thencheck()insteadDescription
part of #201