Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-integer builder.boostFactor #6302

Closed
wemeetagain opened this issue Jan 15, 2024 · 1 comment · Fixed by #6332
Closed

Handle non-integer builder.boostFactor #6302

wemeetagain opened this issue Jan 15, 2024 · 1 comment · Fixed by #6332
Milestone

Comments

@wemeetagain
Copy link
Member

wemeetagain commented Jan 15, 2024

We should handle non-integer builder boost factor especially considering our docs reference the formula that can easily result in a non-integer output.

Possible solutions:

  • round or truncate to integer value, possibly w/ warn log
  • throw friendly error and shutdown, include documentation update to highlight that

Looks good to me now, applied suggestions from @g11tech and fixed example to use an integer value as --builder.boostFactor does not support floating point numbers

Originally posted by @nflaig in #6295 (review)

@philknows philknows added this to the v1.15.0 milestone Jan 16, 2024
@philknows
Copy link
Member

Should probably do this for the next release for the full feature to be implemented properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants