Remove fork designation and fork guard aliases

[nflaig]

Remove fork designation and fork guard aliases

lodestar/packages/params/src/forkName.ts

Lines 97 to 101 in 7347056

	/*
	* Aliases only exported for backwards compatibility. This will be removed in
	* lodestar v2.0. The types and guards above should be used in all places as
	* they are more correct than using the "main feature" from a fork.
	*/

---

Changes below have been implemented by #7441

Somehing we should consider for the 2.0 release is to rename pre / post fork types as current semantics are confusing and require feature awareness of each fork instead of just knowing about the fork name itself, and order of forks, which is simple since it's alphabetical.

e.g.

ForkPreBlobs --> ForkPreDeneb

ForkBlobs --> ForkPostDeneb

isForkBlobs --> isForkPostDeneb

etc.

see https://github.com/ChainSafe/lodestar/blob/unstable/packages/params/src/forkName.ts

[philknows]

Related #7011

[ensi321]

What's the reason we want to wait for 2.0 to make this change? Seems to me is just a straightforward refactor in the code.

Unless this feature is notable enough that we want to promote it as part of 2.0 launch

[nflaig]

What's the reason we want to wait for 2.0 to make this change?

we should avoid breaking changes to @lodestar/types without bumping the major version, in case of this refactor, I don't think it's that urgent

[matthewkeil]

Started this process on peerDAS branch PR #6353 to get the unit tests to pass in params package

fda353d

[nflaig]

unit tests to pass in params package

how is a renaming of functions related to unit tests passing?

[matthewkeil]

unit tests to pass in params package

how is a renaming of functions related to unit tests passing?

Adding fulu to the forkBlobs snapshot array was semantically incorrect. There are also a number of places in the code that ForkBlobs should be used to differentiate blobs vs columns code but that is not how the types/guards are setup.

[nflaig]

Adding fulu to the forkBlobs snapshot array was semantically incorrect.

why? we still have blobs, the only place we use columns instead are on p2p

There are also a number of places in the code that ForkBlobs should be used to differentiate blobs vs columns code

hmm I am not sure if I understand what you mean here but in general can't you just use isForkPostFulu() to run the column code?

[nflaig]

Renaming has been done in #7441, we can keep this issue open to remove the aliases in our 2.0 release.