Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log agent version when client is not known #6314

Merged
merged 2 commits into from
Jan 19, 2024
Merged

feat: log agent version when client is not known #6314

merged 2 commits into from
Jan 19, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jan 17, 2024

Motivation

For unknown clients, the log keeps saying "Unknown" which is not beneficial for debugging purpose

Jan-17 07:38:21.909[network]       verbose: Req  error method=metadata, version=2, encoding=ssz_snappy, client=Unknown, peer=16...pWVhz9, requestId=403654, code=SSZ_SNAPPY_ERROR_OVER_SSZ_MAX_SIZE, maxSize=17, sszDataLength=24
Error: SSZ_SNAPPY_ERROR_OVER_SSZ_MAX_SIZE

Description

  • Log: show agent version of unknown client if we have it
Jan-17 08:52:32.078[network]         debug: Req  sending request method=metadata, version=2, encoding=ssz_snappy, client=erigon/caplin, peer=16...UyvV1M, requestId=2180
  • Or just show "NA" if we event don't have agent version
Jan-17 08:52:30.832[network]         debug: Req  received method=ping, client=NA, peer=16...T6mMb7, requestId=2163
  • Metric: still track them as "Unknown"
Screenshot 2024-01-17 at 15 57 16

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Merging #6314 (5935eb5) into unstable (4ec413c) will increase coverage by 0.08%.
Report is 9 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6314      +/-   ##
============================================
+ Coverage     76.52%   76.61%   +0.08%     
============================================
  Files           248      248              
  Lines         25937    25898      -39     
  Branches       1449     1448       -1     
============================================
- Hits          19849    19842       -7     
+ Misses         6058     6026      -32     
  Partials         30       30

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite Current: 158f0ff Previous: ea4cdad Ratio
Map set x1000 53.450 ns/op 17.558 ns/op 3.04
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 11.515 us/op 3.7150 us/op 3.10
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 15.735 us/op 4.4090 us/op 3.57
Full benchmark results
Benchmark suite Current: 158f0ff Previous: ea4cdad Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 560.78 us/op 845.57 us/op 0.66
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 120.35 us/op 87.344 us/op 1.38
BLS verify - blst-native 1.3659 ms/op 1.0954 ms/op 1.25
BLS verifyMultipleSignatures 3 - blst-native 2.8560 ms/op 2.3661 ms/op 1.21
BLS verifyMultipleSignatures 8 - blst-native 6.3516 ms/op 5.3253 ms/op 1.19
BLS verifyMultipleSignatures 32 - blst-native 23.090 ms/op 19.553 ms/op 1.18
BLS verifyMultipleSignatures 64 - blst-native 45.462 ms/op 38.858 ms/op 1.17
BLS verifyMultipleSignatures 128 - blst-native 92.212 ms/op 77.730 ms/op 1.19
BLS deserializing 10000 signatures 987.75 ms/op 823.35 ms/op 1.20
BLS deserializing 100000 signatures 9.6154 s/op 8.2558 s/op 1.16
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.4515 ms/op 1.1401 ms/op 1.27
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5575 ms/op 1.2852 ms/op 1.21
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.3884 ms/op 2.4333 ms/op 0.98
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.5110 ms/op 3.4817 ms/op 1.01
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.7279 ms/op 4.9668 ms/op 1.15
BLS aggregatePubkeys 32 - blst-native 26.763 us/op 22.542 us/op 1.19
BLS aggregatePubkeys 128 - blst-native 104.04 us/op 88.558 us/op 1.17
getAttestationsForBlock 50.304 ms/op 41.188 ms/op 1.22
getSlashingsAndExits - default max 146.78 us/op 115.65 us/op 1.27
getSlashingsAndExits - 2k 428.48 us/op 306.12 us/op 1.40
proposeBlockBody type=full, size=empty 6.1647 ms/op 4.0500 ms/op 1.52
isKnown best case - 1 super set check 377.00 ns/op 565.00 ns/op 0.67
isKnown normal case - 2 super set checks 360.00 ns/op 555.00 ns/op 0.65
isKnown worse case - 16 super set checks 335.00 ns/op 567.00 ns/op 0.59
CheckpointStateCache - add get delete 6.2220 us/op 5.0350 us/op 1.24
validate api signedAggregateAndProof - struct 2.9446 ms/op 2.4247 ms/op 1.21
validate gossip signedAggregateAndProof - struct 2.8744 ms/op 2.4078 ms/op 1.19
validate gossip attestation - vc 640000 1.4071 ms/op 1.1828 ms/op 1.19
batch validate gossip attestation - vc 640000 - chunk 32 169.10 us/op 146.58 us/op 1.15
batch validate gossip attestation - vc 640000 - chunk 64 165.49 us/op 130.63 us/op 1.27
batch validate gossip attestation - vc 640000 - chunk 128 152.91 us/op 123.12 us/op 1.24
batch validate gossip attestation - vc 640000 - chunk 256 145.80 us/op 128.08 us/op 1.14
pickEth1Vote - no votes 1.4153 ms/op 1.0244 ms/op 1.38
pickEth1Vote - max votes 13.128 ms/op 10.187 ms/op 1.29
pickEth1Vote - Eth1Data hashTreeRoot value x2048 22.034 ms/op 15.745 ms/op 1.40
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 28.831 ms/op 28.655 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize value x2048 710.00 us/op 414.26 us/op 1.71
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.0509 ms/op 8.6475 ms/op 0.70
bytes32 toHexString 676.00 ns/op 354.00 ns/op 1.91
bytes32 Buffer.toString(hex) 349.00 ns/op 205.00 ns/op 1.70
bytes32 Buffer.toString(hex) from Uint8Array 909.00 ns/op 309.00 ns/op 2.94
bytes32 Buffer.toString(hex) + 0x 419.00 ns/op 194.00 ns/op 2.16
Object access 1 prop 0.25100 ns/op 0.11100 ns/op 2.26
Map access 1 prop 0.17200 ns/op 0.10100 ns/op 1.70
Object get x1000 7.8610 ns/op 5.2210 ns/op 1.51
Map get x1000 0.87400 ns/op 0.79200 ns/op 1.10
Object set x1000 59.161 ns/op 27.319 ns/op 2.17
Map set x1000 53.450 ns/op 17.558 ns/op 3.04
Return object 10000 times 0.26140 ns/op 0.23070 ns/op 1.13
Throw Error 10000 times 4.1847 us/op 2.8890 us/op 1.45
fastMsgIdFn sha256 / 200 bytes 3.5670 us/op 2.0080 us/op 1.78
fastMsgIdFn h32 xxhash / 200 bytes 350.00 ns/op 254.00 ns/op 1.38
fastMsgIdFn h64 xxhash / 200 bytes 400.00 ns/op 293.00 ns/op 1.37
fastMsgIdFn sha256 / 1000 bytes 12.181 us/op 6.3210 us/op 1.93
fastMsgIdFn h32 xxhash / 1000 bytes 529.00 ns/op 393.00 ns/op 1.35
fastMsgIdFn h64 xxhash / 1000 bytes 512.00 ns/op 369.00 ns/op 1.39
fastMsgIdFn sha256 / 10000 bytes 110.52 us/op 53.754 us/op 2.06
fastMsgIdFn h32 xxhash / 10000 bytes 2.1630 us/op 1.9000 us/op 1.14
fastMsgIdFn h64 xxhash / 10000 bytes 1.4930 us/op 1.1830 us/op 1.26
send data - 1000 256B messages 21.485 ms/op 14.367 ms/op 1.50
send data - 1000 512B messages 32.003 ms/op 21.262 ms/op 1.51
send data - 1000 1024B messages 49.312 ms/op 32.568 ms/op 1.51
send data - 1000 1200B messages 43.484 ms/op 37.930 ms/op 1.15
send data - 1000 2048B messages 29.838 ms/op 47.571 ms/op 0.63
send data - 1000 4096B messages 53.428 ms/op 41.817 ms/op 1.28
send data - 1000 16384B messages 125.39 ms/op 113.31 ms/op 1.11
send data - 1000 65536B messages 582.62 ms/op 455.28 ms/op 1.28
enrSubnets - fastDeserialize 64 bits 1.7440 us/op 1.0220 us/op 1.71
enrSubnets - ssz BitVector 64 bits 573.00 ns/op 421.00 ns/op 1.36
enrSubnets - fastDeserialize 4 bits 256.00 ns/op 139.00 ns/op 1.84
enrSubnets - ssz BitVector 4 bits 649.00 ns/op 401.00 ns/op 1.62
prioritizePeers score -10:0 att 32-0.1 sync 2-0 122.15 us/op 84.064 us/op 1.45
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 147.28 us/op 111.74 us/op 1.32
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 206.70 us/op 166.17 us/op 1.24
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 358.80 us/op 275.67 us/op 1.30
prioritizePeers score 0:0 att 64-1 sync 4-1 381.06 us/op 315.43 us/op 1.21
array of 16000 items push then shift 1.8031 us/op 1.3896 us/op 1.30
LinkedList of 16000 items push then shift 9.9160 ns/op 6.5940 ns/op 1.50
array of 16000 items push then pop 122.04 ns/op 114.88 ns/op 1.06
LinkedList of 16000 items push then pop 9.8520 ns/op 6.6000 ns/op 1.49
array of 24000 items push then shift 2.6491 us/op 2.0031 us/op 1.32
LinkedList of 24000 items push then shift 9.4960 ns/op 10.272 ns/op 0.92
array of 24000 items push then pop 156.18 ns/op 173.35 ns/op 0.90
LinkedList of 24000 items push then pop 9.5680 ns/op 5.8660 ns/op 1.63
intersect bitArray bitLen 8 6.9040 ns/op 5.4150 ns/op 1.27
intersect array and set length 8 72.581 ns/op 49.712 ns/op 1.46
intersect bitArray bitLen 128 34.770 ns/op 28.448 ns/op 1.22
intersect array and set length 128 1.1289 us/op 736.36 ns/op 1.53
bitArray.getTrueBitIndexes() bitLen 128 1.8890 us/op 1.5870 us/op 1.19
bitArray.getTrueBitIndexes() bitLen 248 3.2970 us/op 2.9940 us/op 1.10
bitArray.getTrueBitIndexes() bitLen 512 6.7960 us/op 6.2920 us/op 1.08
Buffer.concat 32 items 1.2490 us/op 890.00 ns/op 1.40
Uint8Array.set 32 items 2.0780 us/op 1.6780 us/op 1.24
Set add up to 64 items then delete first 5.0809 us/op 2.5204 us/op 2.02
OrderedSet add up to 64 items then delete first 6.4474 us/op 3.9496 us/op 1.63
Set add up to 64 items then delete last 5.5683 us/op 2.7205 us/op 2.05
OrderedSet add up to 64 items then delete last 7.1406 us/op 4.3201 us/op 1.65
Set add up to 64 items then delete middle 5.4143 us/op 2.7549 us/op 1.97
OrderedSet add up to 64 items then delete middle 8.2587 us/op 5.5489 us/op 1.49
Set add up to 128 items then delete first 10.920 us/op 5.2815 us/op 2.07
OrderedSet add up to 128 items then delete first 14.718 us/op 8.2628 us/op 1.78
Set add up to 128 items then delete last 10.687 us/op 4.9656 us/op 2.15
OrderedSet add up to 128 items then delete last 14.425 us/op 7.7623 us/op 1.86
Set add up to 128 items then delete middle 10.980 us/op 5.3568 us/op 2.05
OrderedSet add up to 128 items then delete middle 19.189 us/op 13.365 us/op 1.44
Set add up to 256 items then delete first 21.708 us/op 10.707 us/op 2.03
OrderedSet add up to 256 items then delete first 31.651 us/op 17.081 us/op 1.85
Set add up to 256 items then delete last 21.474 us/op 10.522 us/op 2.04
OrderedSet add up to 256 items then delete last 29.197 us/op 14.705 us/op 1.99
Set add up to 256 items then delete middle 21.028 us/op 10.037 us/op 2.10
OrderedSet add up to 256 items then delete middle 52.526 us/op 35.919 us/op 1.46
transfer serialized Status (84 B) 1.8910 us/op 1.5110 us/op 1.25
copy serialized Status (84 B) 1.4110 us/op 1.1660 us/op 1.21
transfer serialized SignedVoluntaryExit (112 B) 2.0360 us/op 1.5590 us/op 1.31
copy serialized SignedVoluntaryExit (112 B) 1.5270 us/op 1.2090 us/op 1.26
transfer serialized ProposerSlashing (416 B) 2.2740 us/op 1.8990 us/op 1.20
copy serialized ProposerSlashing (416 B) 1.9570 us/op 1.8410 us/op 1.06
transfer serialized Attestation (485 B) 2.3310 us/op 1.9940 us/op 1.17
copy serialized Attestation (485 B) 2.1220 us/op 1.9010 us/op 1.12
transfer serialized AttesterSlashing (33232 B) 2.2400 us/op 1.5240 us/op 1.47
copy serialized AttesterSlashing (33232 B) 7.9790 us/op 7.9340 us/op 1.01
transfer serialized Small SignedBeaconBlock (128000 B) 2.8190 us/op 1.8260 us/op 1.54
copy serialized Small SignedBeaconBlock (128000 B) 20.812 us/op 25.747 us/op 0.81
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1580 us/op 1.9480 us/op 1.62
copy serialized Avg SignedBeaconBlock (200000 B) 33.069 us/op 42.152 us/op 0.78
transfer serialized BlobsSidecar (524380 B) 3.7780 us/op 2.3390 us/op 1.62
copy serialized BlobsSidecar (524380 B) 122.97 us/op 183.13 us/op 0.67
transfer serialized Big SignedBeaconBlock (1000000 B) 4.2420 us/op 3.0720 us/op 1.38
copy serialized Big SignedBeaconBlock (1000000 B) 286.14 us/op 278.15 us/op 1.03
pass gossip attestations to forkchoice per slot 4.5913 ms/op 2.8200 ms/op 1.63
forkChoice updateHead vc 100000 bc 64 eq 0 712.51 us/op 465.73 us/op 1.53
forkChoice updateHead vc 600000 bc 64 eq 0 4.7771 ms/op 3.0348 ms/op 1.57
forkChoice updateHead vc 1000000 bc 64 eq 0 7.4907 ms/op 4.5694 ms/op 1.64
forkChoice updateHead vc 600000 bc 320 eq 0 4.5262 ms/op 2.6901 ms/op 1.68
forkChoice updateHead vc 600000 bc 1200 eq 0 4.5130 ms/op 2.7404 ms/op 1.65
forkChoice updateHead vc 600000 bc 7200 eq 0 6.1073 ms/op 3.7514 ms/op 1.63
forkChoice updateHead vc 600000 bc 64 eq 1000 11.629 ms/op 10.050 ms/op 1.16
forkChoice updateHead vc 600000 bc 64 eq 10000 12.440 ms/op 9.8486 ms/op 1.26
forkChoice updateHead vc 600000 bc 64 eq 300000 18.028 ms/op 12.354 ms/op 1.46
computeDeltas 500000 validators 300 proto nodes 7.7297 ms/op 3.1688 ms/op 2.44
computeDeltas 500000 validators 1200 proto nodes 6.8548 ms/op 2.9780 ms/op 2.30
computeDeltas 500000 validators 7200 proto nodes 6.5880 ms/op 2.8549 ms/op 2.31
computeDeltas 750000 validators 300 proto nodes 10.216 ms/op 4.3259 ms/op 2.36
computeDeltas 750000 validators 1200 proto nodes 10.130 ms/op 4.4229 ms/op 2.29
computeDeltas 750000 validators 7200 proto nodes 10.162 ms/op 4.3462 ms/op 2.34
computeDeltas 1400000 validators 300 proto nodes 19.574 ms/op 8.4912 ms/op 2.31
computeDeltas 1400000 validators 1200 proto nodes 19.133 ms/op 8.4567 ms/op 2.26
computeDeltas 1400000 validators 7200 proto nodes 19.196 ms/op 9.0931 ms/op 2.11
computeDeltas 2100000 validators 300 proto nodes 28.403 ms/op 13.887 ms/op 2.05
computeDeltas 2100000 validators 1200 proto nodes 28.645 ms/op 13.452 ms/op 2.13
computeDeltas 2100000 validators 7200 proto nodes 29.188 ms/op 13.350 ms/op 2.19
altair processAttestation - 250000 vs - 7PWei normalcase 2.2991 ms/op 1.9969 ms/op 1.15
altair processAttestation - 250000 vs - 7PWei worstcase 3.6007 ms/op 2.6677 ms/op 1.35
altair processAttestation - setStatus - 1/6 committees join 188.19 us/op 90.138 us/op 2.09
altair processAttestation - setStatus - 1/3 committees join 356.47 us/op 174.83 us/op 2.04
altair processAttestation - setStatus - 1/2 committees join 477.40 us/op 232.70 us/op 2.05
altair processAttestation - setStatus - 2/3 committees join 607.77 us/op 296.00 us/op 2.05
altair processAttestation - setStatus - 4/5 committees join 799.58 us/op 410.02 us/op 1.95
altair processAttestation - setStatus - 100% committees join 951.18 us/op 542.69 us/op 1.75
altair processBlock - 250000 vs - 7PWei normalcase 10.506 ms/op 8.8227 ms/op 1.19
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.572 ms/op 33.288 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase 38.754 ms/op 33.431 ms/op 1.16
altair processBlock - 250000 vs - 7PWei worstcase hashState 99.379 ms/op 80.519 ms/op 1.23
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2618 ms/op 1.9404 ms/op 1.68
phase0 processBlock - 250000 vs - 7PWei worstcase 31.727 ms/op 28.928 ms/op 1.10
altair processEth1Data - 250000 vs - 7PWei normalcase 535.29 us/op 320.19 us/op 1.67
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 11.515 us/op 3.7150 us/op 3.10
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 39.733 us/op 38.203 us/op 1.04
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 18.139 us/op 9.3820 us/op 1.93
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 15.735 us/op 4.4090 us/op 3.57
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 210.14 us/op 125.49 us/op 1.67
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.6102 ms/op 824.92 us/op 1.95
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.4433 ms/op 1.0902 ms/op 2.24
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6923 ms/op 1.0008 ms/op 1.69
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 5.1894 ms/op 2.3989 ms/op 2.16
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.1709 ms/op 1.5767 ms/op 2.01
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 7.4341 ms/op 3.9101 ms/op 1.90
Tree 40 250000 create 639.14 ms/op 262.52 ms/op 2.43
Tree 40 250000 get(125000) 230.59 ns/op 112.38 ns/op 2.05
Tree 40 250000 set(125000) 1.5254 us/op 760.98 ns/op 2.00
Tree 40 250000 toArray() 25.074 ms/op 13.265 ms/op 1.89
Tree 40 250000 iterate all - toArray() + loop 26.339 ms/op 10.554 ms/op 2.50
Tree 40 250000 iterate all - get(i) 80.186 ms/op 45.454 ms/op 1.76
MutableVector 250000 create 20.607 ms/op 10.605 ms/op 1.94
MutableVector 250000 get(125000) 7.2260 ns/op 5.5060 ns/op 1.31
MutableVector 250000 set(125000) 417.31 ns/op 199.10 ns/op 2.10
MutableVector 250000 toArray() 4.1622 ms/op 3.7689 ms/op 1.10
MutableVector 250000 iterate all - toArray() + loop 4.6726 ms/op 2.6108 ms/op 1.79
MutableVector 250000 iterate all - get(i) 1.6096 ms/op 1.3339 ms/op 1.21
Array 250000 create 3.8972 ms/op 2.4185 ms/op 1.61
Array 250000 clone - spread 1.5390 ms/op 1.0808 ms/op 1.42
Array 250000 get(125000) 1.4430 ns/op 0.94100 ns/op 1.53
Array 250000 set(125000) 5.6410 ns/op 1.1210 ns/op 5.03
Array 250000 iterate all - loop 215.42 us/op 154.90 us/op 1.39
effectiveBalanceIncrements clone Uint8Array 300000 64.218 us/op 12.639 us/op 5.08
effectiveBalanceIncrements clone MutableVector 300000 451.00 ns/op 298.00 ns/op 1.51
effectiveBalanceIncrements rw all Uint8Array 300000 212.48 us/op 184.96 us/op 1.15
effectiveBalanceIncrements rw all MutableVector 300000 122.21 ms/op 63.614 ms/op 1.92
phase0 afterProcessEpoch - 250000 vs - 7PWei 123.24 ms/op 78.924 ms/op 1.56
phase0 beforeProcessEpoch - 250000 vs - 7PWei 61.694 ms/op 51.014 ms/op 1.21
altair processEpoch - mainnet_e81889 647.59 ms/op 456.32 ms/op 1.42
mainnet_e81889 - altair beforeProcessEpoch 99.554 ms/op 81.870 ms/op 1.22
mainnet_e81889 - altair processJustificationAndFinalization 19.824 us/op 8.5720 us/op 2.31
mainnet_e81889 - altair processInactivityUpdates 8.0980 ms/op 6.6446 ms/op 1.22
mainnet_e81889 - altair processRewardsAndPenalties 77.098 ms/op 58.042 ms/op 1.33
mainnet_e81889 - altair processRegistryUpdates 3.5090 us/op 1.2070 us/op 2.91
mainnet_e81889 - altair processSlashings 983.00 ns/op 409.00 ns/op 2.40
mainnet_e81889 - altair processEth1DataReset 1.7510 us/op 498.00 ns/op 3.52
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.5008 ms/op 1.1097 ms/op 1.35
mainnet_e81889 - altair processSlashingsReset 4.5960 us/op 4.1820 us/op 1.10
mainnet_e81889 - altair processRandaoMixesReset 5.6570 us/op 5.0080 us/op 1.13
mainnet_e81889 - altair processHistoricalRootsUpdate 1.8210 us/op 606.00 ns/op 3.00
mainnet_e81889 - altair processParticipationFlagUpdates 2.5900 us/op 3.0110 us/op 0.86
mainnet_e81889 - altair processSyncCommitteeUpdates 837.00 ns/op 774.00 ns/op 1.08
mainnet_e81889 - altair afterProcessEpoch 143.90 ms/op 89.000 ms/op 1.62
capella processEpoch - mainnet_e217614 4.2653 s/op 2.2757 s/op 1.87
mainnet_e217614 - capella beforeProcessEpoch 915.99 ms/op 498.56 ms/op 1.84
mainnet_e217614 - capella processJustificationAndFinalization 45.498 us/op 8.2870 us/op 5.49
mainnet_e217614 - capella processInactivityUpdates 46.335 ms/op 15.497 ms/op 2.99
mainnet_e217614 - capella processRewardsAndPenalties 526.74 ms/op 398.71 ms/op 1.32
mainnet_e217614 - capella processRegistryUpdates 38.605 us/op 22.399 us/op 1.72
mainnet_e217614 - capella processSlashings 938.00 ns/op 616.00 ns/op 1.52
mainnet_e217614 - capella processEth1DataReset 824.00 ns/op 219.00 ns/op 3.76
mainnet_e217614 - capella processEffectiveBalanceUpdates 5.9220 ms/op 5.0092 ms/op 1.18
mainnet_e217614 - capella processSlashingsReset 3.8010 us/op 3.5790 us/op 1.06
mainnet_e217614 - capella processRandaoMixesReset 5.6720 us/op 4.9620 us/op 1.14
mainnet_e217614 - capella processHistoricalRootsUpdate 529.00 ns/op 346.00 ns/op 1.53
mainnet_e217614 - capella processParticipationFlagUpdates 1.7440 us/op 1.2510 us/op 1.39
mainnet_e217614 - capella afterProcessEpoch 338.26 ms/op 212.97 ms/op 1.59
phase0 processEpoch - mainnet_e58758 466.76 ms/op 438.54 ms/op 1.06
mainnet_e58758 - phase0 beforeProcessEpoch 148.17 ms/op 120.20 ms/op 1.23
mainnet_e58758 - phase0 processJustificationAndFinalization 16.587 us/op 8.5110 us/op 1.95
mainnet_e58758 - phase0 processRewardsAndPenalties 54.314 ms/op 44.184 ms/op 1.23
mainnet_e58758 - phase0 processRegistryUpdates 12.076 us/op 4.0940 us/op 2.95
mainnet_e58758 - phase0 processSlashings 524.00 ns/op 217.00 ns/op 2.41
mainnet_e58758 - phase0 processEth1DataReset 482.00 ns/op 314.00 ns/op 1.54
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1904 ms/op 835.37 us/op 1.43
mainnet_e58758 - phase0 processSlashingsReset 4.4500 us/op 3.7170 us/op 1.20
mainnet_e58758 - phase0 processRandaoMixesReset 6.5080 us/op 4.0530 us/op 1.61
mainnet_e58758 - phase0 processHistoricalRootsUpdate 669.00 ns/op 306.00 ns/op 2.19
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.4130 us/op 1.8530 us/op 4.00
mainnet_e58758 - phase0 afterProcessEpoch 97.930 ms/op 65.874 ms/op 1.49
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.4161 ms/op 1.0389 ms/op 1.36
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5292 ms/op 1.1162 ms/op 1.37
altair processInactivityUpdates - 250000 normalcase 39.166 ms/op 22.819 ms/op 1.72
altair processInactivityUpdates - 250000 worstcase 36.415 ms/op 22.811 ms/op 1.60
phase0 processRegistryUpdates - 250000 normalcase 13.762 us/op 3.5790 us/op 3.85
phase0 processRegistryUpdates - 250000 badcase_full_deposits 430.40 us/op 261.22 us/op 1.65
phase0 processRegistryUpdates - 250000 worstcase 0.5 190.35 ms/op 114.67 ms/op 1.66
altair processRewardsAndPenalties - 250000 normalcase 54.875 ms/op 47.050 ms/op 1.17
altair processRewardsAndPenalties - 250000 worstcase 62.225 ms/op 54.059 ms/op 1.15
phase0 getAttestationDeltas - 250000 normalcase 11.279 ms/op 9.1407 ms/op 1.23
phase0 getAttestationDeltas - 250000 worstcase 12.177 ms/op 7.0746 ms/op 1.72
phase0 processSlashings - 250000 worstcase 120.35 us/op 59.090 us/op 2.04
altair processSyncCommitteeUpdates - 250000 171.74 ms/op 127.56 ms/op 1.35
BeaconState.hashTreeRoot - No change 533.00 ns/op 220.00 ns/op 2.42
BeaconState.hashTreeRoot - 1 full validator 177.91 us/op 161.53 us/op 1.10
BeaconState.hashTreeRoot - 32 full validator 1.7046 ms/op 1.2748 ms/op 1.34
BeaconState.hashTreeRoot - 512 full validator 20.177 ms/op 15.571 ms/op 1.30
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 221.10 us/op 153.69 us/op 1.44
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.5828 ms/op 1.9203 ms/op 1.35
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 32.343 ms/op 30.297 ms/op 1.07
BeaconState.hashTreeRoot - 1 balances 158.59 us/op 131.87 us/op 1.20
BeaconState.hashTreeRoot - 32 balances 1.2711 ms/op 1.5311 ms/op 0.83
BeaconState.hashTreeRoot - 512 balances 13.417 ms/op 10.073 ms/op 1.33
BeaconState.hashTreeRoot - 250000 balances 203.55 ms/op 164.35 ms/op 1.24
aggregationBits - 2048 els - zipIndexesInBitList 20.079 us/op 12.437 us/op 1.61
byteArrayEquals 32 76.884 ns/op 70.042 ns/op 1.10
Buffer.compare 32 56.328 ns/op 41.676 ns/op 1.35
byteArrayEquals 1024 2.1076 us/op 1.8660 us/op 1.13
Buffer.compare 1024 73.303 ns/op 46.757 ns/op 1.57
byteArrayEquals 16384 33.163 us/op 28.960 us/op 1.15
Buffer.compare 16384 263.79 ns/op 231.83 ns/op 1.14
byteArrayEquals 123687377 253.50 ms/op 217.69 ms/op 1.16
Buffer.compare 123687377 8.0485 ms/op 6.4326 ms/op 1.25
byteArrayEquals 32 - diff last byte 75.698 ns/op 60.504 ns/op 1.25
Buffer.compare 32 - diff last byte 58.287 ns/op 37.730 ns/op 1.54
byteArrayEquals 1024 - diff last byte 2.1854 us/op 1.6941 us/op 1.29
Buffer.compare 1024 - diff last byte 74.996 ns/op 48.071 ns/op 1.56
byteArrayEquals 16384 - diff last byte 33.886 us/op 27.135 us/op 1.25
Buffer.compare 16384 - diff last byte 293.83 ns/op 196.99 ns/op 1.49
byteArrayEquals 123687377 - diff last byte 275.19 ms/op 205.46 ms/op 1.34
Buffer.compare 123687377 - diff last byte 10.839 ms/op 6.5881 ms/op 1.65
byteArrayEquals 32 - random bytes 7.1500 ns/op 5.4220 ns/op 1.32
Buffer.compare 32 - random bytes 69.992 ns/op 39.225 ns/op 1.78
byteArrayEquals 1024 - random bytes 7.1080 ns/op 5.5730 ns/op 1.28
Buffer.compare 1024 - random bytes 70.674 ns/op 37.470 ns/op 1.89
byteArrayEquals 16384 - random bytes 7.3160 ns/op 5.0810 ns/op 1.44
Buffer.compare 16384 - random bytes 66.206 ns/op 36.988 ns/op 1.79
byteArrayEquals 123687377 - random bytes 12.600 ns/op 7.3500 ns/op 1.71
Buffer.compare 123687377 - random bytes 82.860 ns/op 46.090 ns/op 1.80
regular array get 100000 times 50.593 us/op 42.562 us/op 1.19
wrappedArray get 100000 times 51.259 us/op 42.129 us/op 1.22
arrayWithProxy get 100000 times 17.321 ms/op 9.8656 ms/op 1.76
ssz.Root.equals 61.601 ns/op 56.228 ns/op 1.10
byteArrayEquals 59.133 ns/op 57.189 ns/op 1.03
Buffer.compare 14.658 ns/op 9.5750 ns/op 1.53
shuffle list - 16384 els 7.5356 ms/op 4.7380 ms/op 1.59
shuffle list - 250000 els 116.49 ms/op 70.468 ms/op 1.65
processSlot - 1 slots 23.535 us/op 16.876 us/op 1.39
processSlot - 32 slots 5.3693 ms/op 2.6759 ms/op 2.01
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 69.621 ms/op 51.872 ms/op 1.34
getCommitteeAssignments - req 1 vs - 250000 vc 2.6984 ms/op 2.2554 ms/op 1.20
getCommitteeAssignments - req 100 vs - 250000 vc 3.9975 ms/op 3.4010 ms/op 1.18
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1769 ms/op 3.7177 ms/op 1.12
findModifiedValidators - 10000 modified validators 628.72 ms/op 450.27 ms/op 1.40
findModifiedValidators - 1000 modified validators 509.74 ms/op 352.50 ms/op 1.45
findModifiedValidators - 100 modified validators 524.96 ms/op 326.35 ms/op 1.61
findModifiedValidators - 10 modified validators 539.12 ms/op 335.22 ms/op 1.61
findModifiedValidators - 1 modified validators 526.21 ms/op 339.26 ms/op 1.55
findModifiedValidators - no difference 591.84 ms/op 317.31 ms/op 1.87
compare ViewDUs 5.7590 s/op 3.6755 s/op 1.57
compare each validator Uint8Array 2.2800 s/op 926.57 ms/op 2.46
compare ViewDU to Uint8Array 1.6632 s/op 908.79 ms/op 1.83
migrate state 1000000 validators, 24 modified, 0 new 994.90 ms/op 656.50 ms/op 1.52
migrate state 1000000 validators, 1700 modified, 1000 new 1.2433 s/op 1.0806 s/op 1.15
migrate state 1000000 validators, 3400 modified, 2000 new 1.4987 s/op 1.3965 s/op 1.07
migrate state 1500000 validators, 24 modified, 0 new 854.83 ms/op 710.62 ms/op 1.20
migrate state 1500000 validators, 1700 modified, 1000 new 1.1090 s/op 951.86 ms/op 1.17
migrate state 1500000 validators, 3400 modified, 2000 new 1.3871 s/op 1.1503 s/op 1.21
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.7300 ns/op 3.4500 ns/op 1.37
state getBlockRootAtSlot - 250000 vs - 7PWei 621.01 ns/op 627.71 ns/op 0.99
computeProposers - vc 250000 9.4828 ms/op 5.9566 ms/op 1.59
computeEpochShuffling - vc 250000 106.21 ms/op 66.530 ms/op 1.60
getNextSyncCommittee - vc 250000 161.08 ms/op 100.73 ms/op 1.60
computeSigningRoot for AttestationData 27.317 us/op 25.667 us/op 1.06
hash AttestationData serialized data then Buffer.toString(base64) 2.3973 us/op 1.1808 us/op 2.03
toHexString serialized data 1.1849 us/op 738.78 ns/op 1.60
Buffer.toString(base64) 236.36 ns/op 152.80 ns/op 1.55

by benchmarkbot/action

@twoeths twoeths marked this pull request as ready for review January 19, 2024 09:22
@twoeths twoeths requested a review from a team as a code owner January 19, 2024 09:22
@wemeetagain wemeetagain merged commit c423687 into unstable Jan 19, 2024
12 of 15 checks passed
@wemeetagain wemeetagain deleted the tuyen/log_agent_version branch January 19, 2024 19:31
ensi321 pushed a commit to ensi321/lodestar that referenced this pull request Jan 22, 2024
@twoeths @ensi321
feat: log agent version when client is not known (ChainSafe#6314)
8003862 
* feat: log agent version when client is not known

* chore: add test case for getKnownClientFromAgentVersion
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.15.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@jeluard jeluard jeluard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twoeths @wemeetagain @jeluard @nflaig