Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bugs in dealing with datasets that cancel each other #1

Open
olaurino opened this issue Nov 13, 2014 · 0 comments
Open

Two bugs in dealing with datasets that cancel each other #1

olaurino opened this issue Nov 13, 2014 · 0 comments

Comments

@olaurino
Copy link
Member

According to the Sherpa-Specview interface design, a client should be able to send a message (e.g. calc_model_values) with several datasets that can be simultaneously fitted or evaluated.

However, this does not work as expected, although the current Iris implementation never relies on this feature, so it does not impact this functionality.

In sherpa_samp/mtypes.py, line 890, it is assumed that there is only one dataset in the session, with id 0:
ui.session.get_data(0).x

Also, in sherpa_samp/session.py, method set_model (line 119), it looks like the models are applied to the wrong datasets, looping over the models instead of over the datasets. Again, as multiple datasets are never exercised in Iris, this bug doesn't have an impact, although it impacted the implementation of new features and required working around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant