Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiersten/mentee dashboard/pww 46 #17

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Conversation

KBrennan39
Copy link
Collaborator

No description provided.

Copy link

gitguardian bot commented Nov 17, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14313940 Triggered MongoDB Credentials 12d26d1 api/.env View secret
14289318 Triggered MongoDB Credentials 12d26d1 api/server.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@@ -15,13 +15,12 @@ const Navbar = (): ReactElement => {
></div>
<div className="Flex-row Margin-left--auto">
<div
className="Navbar-body-link Margin-right--20"
// className="Navbar-body-link Margin-right--20"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this comment

Copy link
Collaborator

@lolitaroz lolitaroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! great work!

@lolitaroz lolitaroz merged commit 95b86b1 into main Nov 17, 2024
3 checks passed
@lolitaroz lolitaroz deleted the kiersten/MenteeDashboard/PWW-46 branch November 17, 2024 23:13
@lolitaroz lolitaroz restored the kiersten/MenteeDashboard/PWW-46 branch December 3, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants