implement case-insensitive search functionality + fixed filters #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JiashuHarryHuang
requested changes
Nov 9, 2023
There was a problem hiding this comment.
So fast and really nice work! The Prettier test didn't pass though, so do the following.
- Make sure you have installed Prettier VSCode plugin.
- Type cmd+shift+p
- Search for "format document" and hit enter
4. Turn on "format on save" in VSCode setting so that everytime you hit save, VSCode formats for you.
|
actually fixed prettier issue this time + all checks have been passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement case-insensitive search functionality + fixed filters for most recent and least recent.