Switch from pynput to libvinput #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI needs to be re-run because when I made my latest commit, 1.4 was not uploaded to PyPi, since I was doing development locally to be able to debug the library |
xslendix
force-pushed
the
libvinput
branch
3 times, most recently
from
f242250
to
6639305
Compare
jdestgermain
requested changes
Jul 15, 2024
|
I think @Raymo111 should take care of the installer, I am not familiar with how PyInstaller works. |
jdestgermain
previously approved these changes
Jul 19, 2024
|
macOS broke again im gonna cry |
xslendix
force-pushed
the
libvinput
branch
4 times, most recently
from
171fad2
to
fa33959
Compare
|
Both Linux (X11) and macOS work. |
jdestgermain
previously approved these changes
Jul 25, 2024
xslendix
force-pushed
the
libvinput
branch
2 times, most recently
from
eb4d2aa
to
24ccae6
Compare
Signed-off-by: Slendi <[email protected]>
This is an easier approach IMHO. Signed-off-by: Slendi <[email protected]>
Raymo111
requested changes
Jul 27, 2024
Signed-off-by: Slendi <[email protected]>
Raymo111
requested changes
Jul 28, 2024
Signed-off-by: Slendi <[email protected]>
Raymo111
requested changes
Jul 28, 2024
Signed-off-by: Slendi <[email protected]>
Raymo111
requested changes
Aug 13, 2024
Signed-off-by: Slendi <[email protected]>
Raymo111
reviewed
Aug 13, 2024
Signed-off-by: Slendi <[email protected]>
Raymo111
reviewed
Aug 13, 2024
Signed-off-by: Slendi <[email protected]>
Signed-off-by: Raymond Li <[email protected]>
Raymo111
previously approved these changes
Aug 14, 2024
Edge case where a non-allowed char key (e.g. number) typed fast enough to be considered a chord is added as the first character of a word, and timing is not initialized. When a non-chord key (e.g. modifier key) is then pressed (to end the word), the word is logged but there is no timing associated with it, which would cause a crash.
Raymo111
approved these changes
Aug 15, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to update libvinput first to 1.4 so more types are available outside of the CFFI.