Skip to content
This repository has been archived by the owner on Jan 13, 2018. It is now read-only.

Clean up MenuItemLegacyBarAction #29

Open
Cheesebaron opened this issue Apr 2, 2013 · 5 comments
Open

Clean up MenuItemLegacyBarAction #29

Cheesebaron opened this issue Apr 2, 2013 · 5 comments
Assignees
Labels

Comments

@Cheesebaron
Copy link
Owner

MenuItemLegacyBarAction has both Context and Activity as arguments, is it really necessary?

@jamesmontemagno
Copy link
Collaborator

Most likely not, I think just activity, whichever i use.

@ghost ghost assigned jamesmontemagno Apr 2, 2013
@jamesmontemagno
Copy link
Collaborator

See my latest commit: jamesmontemagno@7993235

I don't really 100% love how I implemented the "MenuItem" originally, perhaps I need to re-imagine it.....

@Cheesebaron
Copy link
Owner Author

What we could do is like ActionBar Sherlock does it. They provide their own MenuItem and their own inflater for it.

@jamesmontemagno
Copy link
Collaborator

I believe this is all fixed up basically now, i think it is fine.

@Cheesebaron
Copy link
Owner Author

My biggest gripe is, when changing the library to API 14, we will need to implement a bunch of stuff in our MenuItem implementation which is API 14 only, which we don't even use, and have to wrap that in #ANDROID_14 pre-compiler tags, which is suuuuper ugly, and VS thinks there is an error. Will have a look at it this weekend though, I might come up with a nice solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants