Skip to content
This repository has been archived by the owner on Jan 13, 2018. It is now read-only.

Could Not Type Load LegacyBar.Library.BarActions.LegacyBarMenuItem #45

Open
Dynogic opened this issue May 23, 2013 · 4 comments
Open

Could Not Type Load LegacyBar.Library.BarActions.LegacyBarMenuItem #45

Dynogic opened this issue May 23, 2013 · 4 comments

Comments

@Dynogic
Copy link

Dynogic commented May 23, 2013

As stated in:
#42

I have also run across this issue, similar to issue 42.

My resolution was to simply remove the line (MenuItemLegacyBarAction):

_menuItem = new LegacyBarMenuItem(menuId, Handle);

And implement the callback using an Action.

Under my testing, LegacyBarMenuItem fails to be ctor'd (the binding fails to attach to Android's MenuItem). I am unable to pinpoint exactly what's causing this. Therefore, I simply removed it.

@Cheesebaron
Copy link
Owner

Try setting minimum target to 2.3 and target to 14 or over and see what happens.

@Dynogic
Copy link
Author

Dynogic commented May 27, 2013

Nope. No avail. I am using a patched version as of now.

It would be great if you could move the LegacyBar to be completely delegate orientated; implementation code will look a lot cleaner on my end. Android doesn't do a great job when it comes to events!

@Cheesebaron
Copy link
Owner

I have created a new branch which is more event driven. Haven't tested much but it seems to work: https://github.com/Cheesebaron/LegacyBar/tree/eventmenu

I have removed LegacyBarMenuItem from the implementation so no handling overflow items going into the old school menu at the moment.

@Dynogic
Copy link
Author

Dynogic commented Jun 7, 2013

Thanks, Cheesebaron!

I will base my project off that branch as soon as time persists.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants