Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the GUI opening speed #31

Open
dixiatielu opened this issue Aug 15, 2020 · 11 comments
Open

Optimize the GUI opening speed #31

dixiatielu opened this issue Aug 15, 2020 · 11 comments
Labels
affects: beta Issues created (or found) on beta builds bug Something isn't working
Milestone

Comments

@dixiatielu
Copy link
Contributor

It took about 8 seconds for a player to open the GUI after performed the /tm command. The server also sent a warning of overloaded. It is necessary to optimize the GUI opening speed.
image

@Chew
Copy link
Member

Chew commented Aug 15, 2020

What version is this on?

@Chew Chew added bug Something isn't working question Further information is requested labels Aug 15, 2020
@dixiatielu
Copy link
Contributor Author

dixiatielu commented Aug 15, 2020

Minecraft 1.15.2, paper build 385.

@Chew
Copy link
Member

Chew commented Aug 15, 2020

No no, the TransmuteIt version, that is useful too

@dixiatielu
Copy link
Contributor Author

dixiatielu commented Aug 15, 2020

The latest developing version, downloaded from your jenkins server yesterday.

@Chew
Copy link
Member

Chew commented Aug 15, 2020

Ah alright, I'll look into that a bit.

@Chew Chew added affects: beta Issues created (or found) on beta builds and removed question Further information is requested labels Aug 15, 2020
@dixiatielu
Copy link
Contributor Author

dixiatielu commented Aug 15, 2020

OK, thanks~

@Chew
Copy link
Member

Chew commented Aug 15, 2020

I couldn't reproduce this with your PR (as that's all I got around to testing atm), so either your PR fixed it or it might be an issue outside of the plugin's scope.

My recommendation (since you have Paper):
Run a /timings start
Do some non-laggy things
Run the GUI commands
Run /timings report

@dixiatielu
Copy link
Contributor Author

dixiatielu commented Aug 15, 2020

I built my pr and tested it, the GUI still opens slowly with my pr. And that's my timings report.

@dixiatielu
Copy link
Contributor Author

I don't know why, I tested it in my real server, it didn't lag at all. But when I tested in my local server, it is still laggy.

@Chew
Copy link
Member

Chew commented Aug 17, 2020

Weird, do any other plugins with GUIs have similar effects?

@dixiatielu
Copy link
Contributor Author

No. I use ChestCommands and GUIShop. Neither of them is laggy when opening the GUI.

@Chew Chew added this to the 0.5.0 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: beta Issues created (or found) on beta builds bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants