Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Microsoft.AspNetCore.Authorization.* attributes on Hot Chocolate resolvers / types #7696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobias-tengler
Copy link
Collaborator

Fixes #7688

@tobias-tengler
Copy link
Collaborator Author

Would be cool if this could be back-ported to v14. The ErrorOnAspNetCoreAuthorizationAttributes schema option simply has to be set to false then, so it's not a breaking change.

@tobias-tengler tobias-tengler force-pushed the tte/error-on-wrong-authorize-attribute branch 3 times, most recently from c30f25a to d3bb3b4 Compare November 7, 2024 18:26
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Nov 7, 2024
@tobias-tengler tobias-tengler force-pushed the tte/error-on-wrong-authorize-attribute branch 2 times, most recently from 0c7598f to 5e234de Compare November 7, 2024 18:39
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (98c8879) to head (723047b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7696      +/-   ##
==========================================
- Coverage   74.33%   74.33%   -0.01%     
==========================================
  Files        2860     2860              
  Lines      149841   149918      +77     
  Branches    17411    17422      +11     
==========================================
+ Hits       111389   111440      +51     
- Misses      32655    32677      +22     
- Partials     5797     5801       +4     
Flag Coverage Δ
unittests 74.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler tobias-tengler force-pushed the tte/error-on-wrong-authorize-attribute branch from 5e234de to 99e5aa1 Compare November 17, 2024 10:04
@tobias-tengler tobias-tengler added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 27, 2024
@tobias-tengler tobias-tengler force-pushed the tte/error-on-wrong-authorize-attribute branch from 99e5aa1 to 723047b Compare November 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate 👓 ready-for-review The PR is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect no-op Microsoft.AspNetCore.Authorization.AuthorizeAttribute
1 participant