Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DEL character in request variables #7759

Open
shravan2x opened this issue Nov 22, 2024 · 2 comments
Open

Allow DEL character in request variables #7759

shravan2x opened this issue Nov 22, 2024 · 2 comments

Comments

@shravan2x
Copy link

Product

Hot Chocolate

Is your feature request related to a problem?

When a DEL character (0x7F) is included in a string passed in as a variable in a hot chocolate mutation call, HC throws an error parsing the request. The actual response returned to the client is something like this:

{
    "errors": [
        {
            "message": "Invalid character within String: 127.",
            "locations": [
                {
                    "line": 1,
                    "column": 3555533
                }
            ],
            "extensions": {
                "code": "HC0011"
            }
        }
    ]
}

The solution you'd like

It appears that characters like DEL are valid per the JSON spec (see discussion in salsify/jsonstreamingparser#53). Could HC allow this character in input data?

@michaelstaib
Copy link
Member

Is it correctly escaped? Your issue needs a repro project that clearly shows the issue.

@shravan2x
Copy link
Author

@michaelstaib I'll try and put a repro together.

@michaelstaib michaelstaib added this to the HC-15.0.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants