Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebot tests cannot be run in parallel #109

Closed
killenb opened this issue Jan 24, 2020 · 3 comments
Closed

Rebot tests cannot be run in parallel #109

killenb opened this issue Jan 24, 2020 · 3 comments
Assignees
@phako
Labels
bug duplicate postponed A ticket that has might have been postponed from being worked on for various reasons selected This ticket has been selected for the MSK software group board

Comments

@killenb
Copy link
Member

killenb commented Jan 24, 2020

The Rebot tests instantiate a dummy server, and all tests use the same port. Hence the tests cannot be run in parallel.

Use different ports. Best use random ports (check how it is done for doocs in the DOOC CS adapter and/or the DOOCS backend)
@mhier
Copy link
Member

mhier commented Jun 2, 2020

Even worse, the tests will fail if run in parallel. Somehow, on Jenkins tests were not run in parallel recently due to a bug in our scripts there. Now this bug has been fixed and the Rebot tests fail consistently. We now have to force all tests of DeviceAccess to run sequentially because of this bug.

@mhier mhier added the bug label Jun 2, 2020
@mhier
Copy link
Member

mhier commented Jun 2, 2020

Minimum solution would be to use a locking mechanism to prevent the tests from failing when running in parallel.

@killenb killenb added selected This ticket has been selected for the MSK software group board urgent High priority ticket and removed urgent High priority ticket labels Jun 2, 2020
@killenb killenb added the postponed A ticket that has might have been postponed from being worked on for various reasons label Aug 5, 2020
@mhier mhier added readyForImplementation This ticket has been moved to the "ready for implementation" area on the MSK software group board and removed postponed A ticket that has might have been postponed from being worked on for various reasons labels Sep 11, 2020
@mhier mhier mentioned this issue Sep 16, 2020
Open
@mhier
Copy link
Member

mhier commented Sep 16, 2020

See #176

@mhier mhier added duplicate postponed A ticket that has might have been postponed from being worked on for various reasons and removed readyForImplementation This ticket has been moved to the "ready for implementation" area on the MSK software group board labels Sep 16, 2020
@phako phako self-assigned this Sep 22, 2020
@phako phako closed this as completed in e12b649 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phako phako

Labels
bug duplicate postponed A ticket that has might have been postponed from being worked on for various reasons selected This ticket has been selected for the MSK software group board
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phako @mhier @killenb