Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A custom tab controller #2

Open
Chinmay-KB opened this issue Sep 1, 2020 · 2 comments
Open

A custom tab controller #2

Chinmay-KB opened this issue Sep 1, 2020 · 2 comments
Labels
Hacktoberfest Contributions under Hacktoberfest 2020 hacktoberfest-2020 help wanted Extra attention is needed

Comments

@Chinmay-KB
Copy link
Owner

The current widget uses a GlobalKey to manage Tab changes, which is not a good practice. A custom controller would be better.
@Chinmay-KB Chinmay-KB added help wanted Extra attention is needed Hacktoberfest Contributions under Hacktoberfest 2020 labels Sep 1, 2020
@Chinmay-KB
Copy link
Owner Author

@all-contributors please add @Chinmay-KB for code

@allcontributors allcontributors bot mentioned this issue Oct 1, 2020
Merged
@allcontributors
Copy link
Contributor

@Chinmay-KB

I've put up a pull request to add @Chinmay-KB! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Contributions under Hacktoberfest 2020 hacktoberfest-2020 help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chinmay-KB