Add support for Binging with Babish and Basics with Babish #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #56 and #15.
These sites are built using a WYSIWYG editor. The pages have an unreliable, ad-hoc structure, and each page usually contains multiple recipes (or recipe variants). The number of servings is rarely given.
Hence, we have to ask the user to choose which ingredient/method lists are wanted (using
completing-read-multiple
), and concatenate them together. (Alternatively we could change theorg-chef
format to allow for labelled sections within the ingredients and method.)Due to the unreliable page structure, my code searches the DOM for
<ul>
and<ol>
elements to find recipes. This seems like a relatively robust strategy.As a side note, a similar approach might be used to make a general fallback parser, since I assume most sites use
<ul>
for ingredients and<ol>
for instructions.