From 3a212920fd05e07356c847e80c3efbc51e0aef23 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 16:46:36 -0400 Subject: [PATCH 01/13] A script to annotate PRs with the regression results. This has to be on the main branch to work, so unfortunately can't test it on a pull request. --- .github/workflows/annotate.yml | 70 ++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 .github/workflows/annotate.yml diff --git a/.github/workflows/annotate.yml b/.github/workflows/annotate.yml new file mode 100644 index 0000000000..49ad4f8271 --- /dev/null +++ b/.github/workflows/annotate.yml @@ -0,0 +1,70 @@ +name: Annotate pull requests with regression summaries + +on: + workflow_run: + workflows: + - Continuous Integration + - Testing + types: + - completed + +jobs: + on-success: + runs-on: ubuntu-latest + if: ${{ github.event.workflow_run.conclusion == 'success' }} + steps: + - run: echo 'The triggering workflow passed' + - name: 'Get triggering pull request number' + id: pr_number + uses: actions/github-script@v6 + with: + script: | + return context.payload.workflow_run.pull_requests[0].number; + - name: 'Report environment variables' + env: + PR_NUMBER: ${{ steps.pr_number.outputs.result }} + run: env + # based on https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow + - name: 'Download regression_summary artifact' + uses: actions/github-script@v6 + with: + script: | + let allArtifacts = await github.rest.actions.listWorkflowRunArtifacts({ + owner: context.repo.owner, + repo: context.repo.repo, + run_id: context.payload.workflow_run.id, + }); + let matchArtifact = allArtifacts.data.artifacts.filter((artifact) => { + return artifact.name == "regression_summary" + })[0]; + let download = await github.rest.actions.downloadArtifact({ + owner: context.repo.owner, + repo: context.repo.repo, + artifact_id: matchArtifact.id, + archive_format: 'zip', + }); + let fs = require('fs'); + fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/regression_summary.zip`, Buffer.from(download.data)); + + - name: 'Unzip artifact' + run: unzip regression_summary.zip + + - name: Write Results to PR + uses: thollander/actions-comment-pull-request@v2 + env: + PR_NUMBER: ${{ steps.pr_number.outputs.result }} + with: + filePath: summary.txt + pr_number: ${{ env.PR_NUMBER }} + + # For debugging + - name: Setup tmate session + uses: mxschmitt/action-tmate@v3 + if: ${{ failure() }} + + on-failure: + runs-on: ubuntu-latest + if: ${{ github.event.workflow_run.conclusion == 'failure' }} + steps: + - run: echo 'The triggering workflow failed' + From 2be81c4390774d44ca556adf7816402cd96a8ce7 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 17:02:38 -0400 Subject: [PATCH 02/13] fixup! A script to annotate PRs with the regression results. --- .github/workflows/annotate.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/annotate.yml b/.github/workflows/annotate.yml index 49ad4f8271..0f77382c52 100644 --- a/.github/workflows/annotate.yml +++ b/.github/workflows/annotate.yml @@ -19,7 +19,8 @@ jobs: uses: actions/github-script@v6 with: script: | - return context.payload.workflow_run.pull_requests[0].number; + console.log(JSON.stringify(context.payload.workflow_run, undefined, 2)); + return context.payload.workflow_run.pull_requests[0]; - name: 'Report environment variables' env: PR_NUMBER: ${{ steps.pr_number.outputs.result }} From 86e1653a8da95232d80929f0815becfc86c3ce9e Mon Sep 17 00:00:00 2001 From: Richard West Date: Wed, 19 Jul 2023 11:56:01 -0400 Subject: [PATCH 03/13] Fix minor logging bug in regression test comparison. --- scripts/checkModels.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/checkModels.py b/scripts/checkModels.py index 65d1a70f8e..f1858a4b7d 100644 --- a/scripts/checkModels.py +++ b/scripts/checkModels.py @@ -111,16 +111,16 @@ def checkModel(commonSpecies, uniqueSpeciesTest, uniqueSpeciesOrig, commonReacti orig_model_species = len(commonSpecies) + len(uniqueSpeciesOrig) logger.error(f"Original model has {orig_model_species} species.") - logger.error(f"Test model has {test_model_species} species." + - '✅' if test_model_species == orig_model_species else '❌') + logger.error(f"Test model has {test_model_species} species. " + + ('✅' if test_model_species == orig_model_species else '❌')) test_model_rxns = len(commonReactions) + len(uniqueReactionsTest) orig_model_rxns = len(commonReactions) + len(uniqueReactionsOrig) logger.error(f"Original model has {orig_model_rxns} reactions.") - logger.error(f"Test model has {test_model_rxns} reactions." + - '✅' if test_model_rxns == orig_model_rxns else '❌') + logger.error(f"Test model has {test_model_rxns} reactions. " + + ('✅' if test_model_rxns == orig_model_rxns else '❌')) return (test_model_species != orig_model_species) or (test_model_rxns != orig_model_rxns) From 68191361313f2956693df3da4b8b4280245f59c2 Mon Sep 17 00:00:00 2001 From: Richard West Date: Thu, 20 Jul 2023 13:28:44 -0400 Subject: [PATCH 04/13] More detailed regression test results in PR annotation. The regression-comparison step now captures its STDOUT (and STDERR) outputs and they are used to create the annotation on the pull request. I tried the mathiasvr/command-output@v2.0.0 workflow, but it doesn't let us use a bash login shell, and maybe has other vulnerabilities. So I reverted to bash and trying to just redirect outputs to files. --- .github/workflows/CI.yml | 44 ++++++++++++++++++++++++---------------- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 2fa92ec72c..6895bedf3b 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -269,6 +269,7 @@ jobs: env: REFERENCE: stable_regression_results run: | + exec 2> >(tee -a regression.stderr >&2) 1> >(tee -a regression.stdout) mkdir -p "test/regression-diff" for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal RMS_constantVIdealGasReactor_superminimal RMS_CSTR_liquid_oxidation; do @@ -284,6 +285,7 @@ jobs: echo -n 'Current: ' grep "Memory used:" test/regression/"$regr_test"/RMG.log | tail -1 + echo "
" # Compare the edge and core if python-jl scripts/checkModels.py \ "$regr_test-core" \ @@ -292,12 +294,15 @@ jobs: test/regression/"$regr_test"/chemkin/chem_annotated.inp \ test/regression/"$regr_test"/chemkin/species_dictionary.txt then - echo "$regr_test Passed Core Comparison" + echo "$regr_test Passed Core Comparison ✅" else - echo "$regr_test Failed Core Comparison" | tee -a $GITHUB_STEP_SUMMARY + echo "$regr_test Failed Core Comparison ❌" | tee -a $GITHUB_STEP_SUMMARY cp "$regr_test-core.log" test/regression-diff/ export FAILED=Yes fi + echo "" + cat "$regr_test-core.log" + echo "
\n
" if python-jl scripts/checkModels.py \ "$regr_test-edge" \ $REFERENCE/"$regr_test"/chemkin/chem_edge_annotated.inp \ @@ -305,59 +310,64 @@ jobs: test/regression/"$regr_test"/chemkin/chem_edge_annotated.inp \ test/regression/"$regr_test"/chemkin/species_edge_dictionary.txt then - echo "$regr_test Passed Edge Comparison" + echo "$regr_test Passed Edge Comparison ✅" else - echo "$regr_test Failed Edge Comparison" | tee -a $GITHUB_STEP_SUMMARY + echo "$regr_test Failed Edge Comparison ❌" | tee -a $GITHUB_STEP_SUMMARY cp "$regr_test-edge.log" test/regression-diff/ export FAILED=Yes fi + echo "" + cat "$regr_test-edge.log" + echo "
\n" # Check for Regression between Reference and Dynamic (skip superminimal) if [ -f test/regression/"$regr_test"/regression_input.py ]; then + echo "
" if python-jl rmgpy/tools/regression.py \ test/regression/"$regr_test"/regression_input.py \ $REFERENCE/"$regr_test"/chemkin \ test/regression/"$regr_test"/chemkin then - echo "$regr_test Passed Observable Testing" + echo "$regr_test Passed Observable Testing ✅" else - echo "$regr_test Failed Observable Testing" | tee -a $GITHUB_STEP_SUMMARY + echo "$regr_test Failed Observable Testing ❌" | tee -a $GITHUB_STEP_SUMMARY export FAILED=Yes fi + echo "
" fi echo "" done if [[ ${FAILED} ]]; then - echo "One or more regression tests failed." | tee -a $GITHUB_STEP_SUMMARY - echo "Please download the failed results and run the tests locally or check the above log to see why." | tee -a $GITHUB_STEP_SUMMARY + echo "⚠️ One or more regression tests failed." | tee -a $GITHUB_STEP_SUMMARY >&2 + echo "Please download the failed results and run the tests locally or check the log to see why." | tee -a $GITHUB_STEP_SUMMARY >&2 fi - name: Prepare Results for PR Comment if : ${{ github.event_name == 'pull_request' }} run: | - echo "
" > summary.txt - echo "Regression Testing Results" >> summary.txt - echo "" >> summary.txt - tail -n +1 test/regression-diff/* >> summary.txt - echo "" + echo "## Regression Testing Results" > summary.txt + cat regression.stderr >> summary.txt + echo "
" >> summary.txt + echo "Detailed regression test results." >> summary.txt + cat regression.stdout >> summary.txt echo "
" >> summary.txt echo "" >> summary.txt - echo "_beep boop this action was performed by a bot_ :robot:" >> summary.txt + echo "_beep boop this comment was written by a bot_ :robot:" >> summary.txt - name: Write Results to PR uses: thollander/actions-comment-pull-request@v2 if : ${{ github.event_name == 'pull_request' }} with: filePath: summary.txt - + - name: Upload Comparison Results uses: actions/upload-artifact@v3 with: name: regression_test_comparison_results path: | test/regression-diff - + # Install and Call codecov only if the tests were successful (permitting failures in the regression comparison tests) - name: Code coverage install and run if: success() || ( failure() && steps.regression-execution.conclusion == 'success' ) @@ -370,7 +380,7 @@ jobs: # technically we could live without the 'needs' since _in theory_ # nothing will ever be merged into main that fails the tests, but # who knows ¯\_(ツ)_/¯ - # + # # taken from https://github.com/docker/build-push-action needs: build-and-test-linux runs-on: ubuntu-latest From f62e24877ca5cc2404e9bb37747de4fccc56cb79 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 10:05:48 -0400 Subject: [PATCH 05/13] Duplicate the regression summary into the actions log. To help debugging. The thing that should become the PR annotation is now duplicated into the summary of the job run. Might be a good idea anyway. --- .github/workflows/CI.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 6895bedf3b..7b8088b34e 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -354,6 +354,7 @@ jobs: echo "
" >> summary.txt echo "" >> summary.txt echo "_beep boop this comment was written by a bot_ :robot:" >> summary.txt + cat summary.txt > $GITHUB_STEP_SUMMARY - name: Write Results to PR uses: thollander/actions-comment-pull-request@v2 From c6fbbb16a547afe2834a74484e6070914ee52bd1 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 12:49:54 -0400 Subject: [PATCH 06/13] CI: don't put failed regression tests into step summarry Looks bad, with new system of putting the full summary there. --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7b8088b34e..0e217429c2 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -296,7 +296,7 @@ jobs: then echo "$regr_test Passed Core Comparison ✅" else - echo "$regr_test Failed Core Comparison ❌" | tee -a $GITHUB_STEP_SUMMARY + echo "$regr_test Failed Core Comparison ❌" cp "$regr_test-core.log" test/regression-diff/ export FAILED=Yes fi @@ -312,7 +312,7 @@ jobs: then echo "$regr_test Passed Edge Comparison ✅" else - echo "$regr_test Failed Edge Comparison ❌" | tee -a $GITHUB_STEP_SUMMARY + echo "$regr_test Failed Edge Comparison ❌" cp "$regr_test-edge.log" test/regression-diff/ export FAILED=Yes fi @@ -331,7 +331,7 @@ jobs: then echo "$regr_test Passed Observable Testing ✅" else - echo "$regr_test Failed Observable Testing ❌" | tee -a $GITHUB_STEP_SUMMARY + echo "$regr_test Failed Observable Testing ❌" export FAILED=Yes fi echo "" From 6026ab72730cdf89f0c8dc36754bf9369aa4dd14 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 13:13:30 -0400 Subject: [PATCH 07/13] Tweak regression test summary markdown. Blank lines needed to make subsequent blocks render as markdown. --- .github/workflows/CI.yml | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 0e217429c2..388860e264 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -274,7 +274,7 @@ jobs: for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal RMS_constantVIdealGasReactor_superminimal RMS_CSTR_liquid_oxidation; do echo "" - echo "## Regression test $regr_test:" + echo "### Regression test $regr_test:" # Memory Usage and Execution Time echo -n 'Reference: ' grep "Execution time" $REFERENCE/"$regr_test"/RMG.log | tail -1 @@ -285,7 +285,7 @@ jobs: echo -n 'Current: ' grep "Memory used:" test/regression/"$regr_test"/RMG.log | tail -1 - echo "
" + echo "
" # Compare the edge and core if python-jl scripts/checkModels.py \ "$regr_test-core" \ @@ -294,15 +294,16 @@ jobs: test/regression/"$regr_test"/chemkin/chem_annotated.inp \ test/regression/"$regr_test"/chemkin/species_dictionary.txt then - echo "$regr_test Passed Core Comparison ✅" + echo "$regr_test Passed Core Comparison ✅" else - echo "$regr_test Failed Core Comparison ❌" + echo "$regr_test Failed Core Comparison ❌" cp "$regr_test-core.log" test/regression-diff/ export FAILED=Yes fi - echo "
" + echo "" # blank line so next block is interpreted as markdown cat "$regr_test-core.log" - echo "
\n
" + echo "
" + echo "
" if python-jl scripts/checkModels.py \ "$regr_test-edge" \ $REFERENCE/"$regr_test"/chemkin/chem_edge_annotated.inp \ @@ -310,15 +311,15 @@ jobs: test/regression/"$regr_test"/chemkin/chem_edge_annotated.inp \ test/regression/"$regr_test"/chemkin/species_edge_dictionary.txt then - echo "$regr_test Passed Edge Comparison ✅" + echo "$regr_test Passed Edge Comparison ✅" else - echo "$regr_test Failed Edge Comparison ❌" + echo "$regr_test Failed Edge Comparison ❌" cp "$regr_test-edge.log" test/regression-diff/ export FAILED=Yes fi - echo "" + echo "" # blank line so next block is interpreted as markdown cat "$regr_test-edge.log" - echo "
\n" + echo "" # Check for Regression between Reference and Dynamic (skip superminimal) if [ -f test/regression/"$regr_test"/regression_input.py ]; From a04011583fa0aebd52da5efd79c07912457e3b8b Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 16:43:59 -0400 Subject: [PATCH 08/13] Upload the regression test summary as an artifact --- .github/workflows/CI.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 388860e264..a0260b97bf 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -357,6 +357,13 @@ jobs: echo "_beep boop this comment was written by a bot_ :robot:" >> summary.txt cat summary.txt > $GITHUB_STEP_SUMMARY + - name: Upload regression summary artifact + uses: actions/upload-artifact@v3 + if : ${{ github.event_name == 'pull_request' }} + with: + name: regression_summary + path: summary.txt + - name: Write Results to PR uses: thollander/actions-comment-pull-request@v2 if : ${{ github.event_name == 'pull_request' }} From 98fb172965de6b5a040a178154e9520f3eec1ba4 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 22:37:19 -0400 Subject: [PATCH 09/13] Get the PR number from the start of the summary file. --- .github/workflows/annotate.yml | 38 ++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/.github/workflows/annotate.yml b/.github/workflows/annotate.yml index 0f77382c52..5d85282d4e 100644 --- a/.github/workflows/annotate.yml +++ b/.github/workflows/annotate.yml @@ -14,17 +14,6 @@ jobs: if: ${{ github.event.workflow_run.conclusion == 'success' }} steps: - run: echo 'The triggering workflow passed' - - name: 'Get triggering pull request number' - id: pr_number - uses: actions/github-script@v6 - with: - script: | - console.log(JSON.stringify(context.payload.workflow_run, undefined, 2)); - return context.payload.workflow_run.pull_requests[0]; - - name: 'Report environment variables' - env: - PR_NUMBER: ${{ steps.pr_number.outputs.result }} - run: env # based on https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow - name: 'Download regression_summary artifact' uses: actions/github-script@v6 @@ -50,6 +39,28 @@ jobs: - name: 'Unzip artifact' run: unzip regression_summary.zip + - name: 'Get pull request number' + id: pr_number + uses: actions/github-script@v6 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + let fs = require('fs'); + let readline = require('readline'); + let issue_number = 0; + const fileStream = fs.createReadStream('summary.txt'); + const rl = readline.createInterface({ + input: fileStream, + crlfDelay: Infinity + }); + rl.on('line', (line) => { + console.log('First line:', line); + issue_number = Number(line); + rl.close(); + fileStream.close(); + return issue_number; + }); + - name: Write Results to PR uses: thollander/actions-comment-pull-request@v2 env: @@ -58,11 +69,6 @@ jobs: filePath: summary.txt pr_number: ${{ env.PR_NUMBER }} - # For debugging - - name: Setup tmate session - uses: mxschmitt/action-tmate@v3 - if: ${{ failure() }} - on-failure: runs-on: ubuntu-latest if: ${{ github.event.workflow_run.conclusion == 'failure' }} From 7c5f716f7a120b28185a6beeec025f0ccbda525c Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 23:27:38 -0400 Subject: [PATCH 10/13] Give up on node.js and use bash! Just trying to get the first line of a damn file. --- .github/workflows/annotate.yml | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/.github/workflows/annotate.yml b/.github/workflows/annotate.yml index 5d85282d4e..3ba8a9a4d5 100644 --- a/.github/workflows/annotate.yml +++ b/.github/workflows/annotate.yml @@ -41,30 +41,11 @@ jobs: - name: 'Get pull request number' id: pr_number - uses: actions/github-script@v6 - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - script: | - let fs = require('fs'); - let readline = require('readline'); - let issue_number = 0; - const fileStream = fs.createReadStream('summary.txt'); - const rl = readline.createInterface({ - input: fileStream, - crlfDelay: Infinity - }); - rl.on('line', (line) => { - console.log('First line:', line); - issue_number = Number(line); - rl.close(); - fileStream.close(); - return issue_number; - }); - + run: | + echo "PR_NUMBER=$( head summary.txt )" >> $GITHUB_ENV + - run: env - name: Write Results to PR uses: thollander/actions-comment-pull-request@v2 - env: - PR_NUMBER: ${{ steps.pr_number.outputs.result }} with: filePath: summary.txt pr_number: ${{ env.PR_NUMBER }} From 3afa9b0d4da7cc4edee84fc2688f50cdf74c78e8 Mon Sep 17 00:00:00 2001 From: Richard West Date: Fri, 21 Jul 2023 23:42:40 -0400 Subject: [PATCH 11/13] Clean up the annotate script --- .github/workflows/annotate.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/annotate.yml b/.github/workflows/annotate.yml index 3ba8a9a4d5..0259844a8f 100644 --- a/.github/workflows/annotate.yml +++ b/.github/workflows/annotate.yml @@ -1,4 +1,9 @@ -name: Annotate pull requests with regression summaries +name: Annotate pull request with regression summaries +# Takes a regression summary from a workflow run and annotates the pull request with it +# The pull request number is taken from the first line of the summary.txt file. +# The summary file is in an artifact called regression_summary associated +# with the workflow run that triggered this workflow. +# based on https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow on: workflow_run: @@ -14,7 +19,6 @@ jobs: if: ${{ github.event.workflow_run.conclusion == 'success' }} steps: - run: echo 'The triggering workflow passed' - # based on https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow - name: 'Download regression_summary artifact' uses: actions/github-script@v6 with: @@ -42,9 +46,10 @@ jobs: - name: 'Get pull request number' id: pr_number run: | - echo "PR_NUMBER=$( head summary.txt )" >> $GITHUB_ENV - - run: env - - name: Write Results to PR + echo "PR_NUMBER=$( head -n 1 summary.txt )" >> $GITHUB_ENV + # remove the first line from the file + sed -i '1d' summary.txt + - name: Write summary to pull request as a comment uses: thollander/actions-comment-pull-request@v2 with: filePath: summary.txt From b54db3a21d9cbe152ec2d765b856c3abbf852ced Mon Sep 17 00:00:00 2001 From: Richard West Date: Sat, 22 Jul 2023 00:07:34 -0400 Subject: [PATCH 12/13] Use annotate workflow to upload the regression summary. We put the pull request number at the start of the summary file, so the other workflow knows which PR to put the comment on. --- .github/workflows/CI.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index a0260b97bf..34978ebde3 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -27,6 +27,7 @@ # 2023-06-15 - revert changes from 06-06, both now work # 2023-06-27 - add option to run from RMG-database with GitHub resuable workflows # 2023-07-17 - made it pass by default +# 2023-07-21 - upload the regression results summary as artifact (for use as a comment on PRs) name: Continuous Integration on: @@ -347,7 +348,8 @@ jobs: - name: Prepare Results for PR Comment if : ${{ github.event_name == 'pull_request' }} run: | - echo "## Regression Testing Results" > summary.txt + echo $PR_NUMBER > summary.txt + echo "## Regression Testing Results" >> summary.txt cat regression.stderr >> summary.txt echo "
" >> summary.txt echo "Detailed regression test results." >> summary.txt @@ -358,18 +360,13 @@ jobs: cat summary.txt > $GITHUB_STEP_SUMMARY - name: Upload regression summary artifact + # the annotate workflow uses this artifact to add a comment to the PR uses: actions/upload-artifact@v3 if : ${{ github.event_name == 'pull_request' }} with: name: regression_summary path: summary.txt - - name: Write Results to PR - uses: thollander/actions-comment-pull-request@v2 - if : ${{ github.event_name == 'pull_request' }} - with: - filePath: summary.txt - - name: Upload Comparison Results uses: actions/upload-artifact@v3 with: From bc9be93ae3753c0c41b645c1a05d13bce9610ec2 Mon Sep 17 00:00:00 2001 From: Richard West Date: Sat, 22 Jul 2023 00:23:11 -0400 Subject: [PATCH 13/13] Remove "Testing" workflow from annotate triggers. (When I was debugging, I had a special workflow to test it more quickly) --- .github/workflows/annotate.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/annotate.yml b/.github/workflows/annotate.yml index 0259844a8f..4e2a1d93a2 100644 --- a/.github/workflows/annotate.yml +++ b/.github/workflows/annotate.yml @@ -9,7 +9,6 @@ on: workflow_run: workflows: - Continuous Integration - - Testing types: - completed