-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact fix: Flatpak #705
refact fix: Flatpak #705
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if any other scripts use flatpak be sure to include these changes
DONT merge this yet, needs more discussing, this implementation is a bit dirty and i feel like we can just combine the flatpak command_exists with the reg one |
1029dcd
to
adad259
Compare
494d27a
to
d877ca8
Compare
d877ca8
to
637fdc5
Compare
Combined both flatpak command_exists ready to be merged !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd wait with this until other PRs that may conflict are resolved.
Chris read before merging !!
Type of Change
Description
common-script
due to path conflicts whensetup-flatpak
is called from different tabs.apk
package manager in case feat: Alpine linux support #814 gets merged. If not removeapk
package manager before mergingpacman
installation section, forcing the script to use flatpak for installation:Note
This issue was originally identified on another laptop running openSUSE. Since no screenshots were captured in openSUSE, the workaround was applied to reproduce the error.
Testing
Additional Description
The idea mentioned in #705 (comment) was not implemented because of the following error
It occurs because
setup-flatpak
is also sourcingcommon-script
and the root sourcing happens in the communication dir (zoom). It will try to accesscommon-script
in the application setup folder instead of trying to source thecommon-script
from the root directoryChecklist