-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: printer driver installation #837
Merged
ChrisTitusTech
merged 13 commits into
ChrisTitusTech:main
from
Vorthas:add-epson-inkjet-printer-driver-installation
Nov 7, 2024
Merged
feat: printer driver installation #837
ChrisTitusTech
merged 13 commits into
ChrisTitusTech:main
from
Vorthas:add-epson-inkjet-printer-driver-installation
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vorthas
changed the title
Add Epson inkjet printer driver installation and printer category under Utilities
Feat: Add Epson inkjet printer driver installation and printer category under Utilities
Oct 15, 2024
cartercanedy
approved these changes
Oct 16, 2024
jeevithakannan2
suggested changes
Oct 20, 2024
Co-authored-by: JEEVITHA KANNAN K S <[email protected]>
adamperkowski
changed the title
Feat: Add Epson inkjet printer driver installation and printer category under Utilities
feat: printer driver installation
Oct 25, 2024
I don't know about this... |
Should probably install |
Think CUPS installation should be done in a separate script that this script calls? Since I'd imagine most printer drivers for Linux would need CUPS as a dependency. |
… as well as standalone script for other printer drivers to be added in the future.
Yeah would be a good idea to have |
adamperkowski
requested changes
Oct 30, 2024
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
adamperkowski
approved these changes
Oct 31, 2024
ChrisTitusTech
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Came to mind to add this when I was struggling to get my Epson printer working earlier today on my new computer. Turns out I forgot to install the Epson printer drivers in the AUR. I did a search and the same package is in the Debian and Fedora repos so I added support for those, but I'm not really able to test them myself as I only use EndeavourOS. I can comment those out in the shell script if needed.
Testing
Ran the script and verified it installed (or reinstalled in my case) the correct drivers and saw them show up in CUPS when I brought up the CUPS web interface.
Impact
Printer driver installation on Linux (and on Windows for that matter) is a real pain to get right sometimes, I'm hoping this will help people out who use Epson printers.
Issues / other PRs related
N/A
Additional Information
As I mentioned in description, I only really tested this on an Arch-based distro. May need some help testing this on a Debian- or Fedora-based distro.
Checklist