Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use externalInfoUrl for custom rules #162

Open
nicolas1bruno opened this issue Apr 15, 2024 · 1 comment
Open

Use externalInfoUrl for custom rules #162

nicolas1bruno opened this issue Apr 15, 2024 · 1 comment

Comments

@nicolas1bruno
Copy link

nicolas1bruno commented Apr 15, 2024

Is your feature request related to a problem? Please describe.
When running Apex PMD with a custom ruleset, with custom rules in it, the url provided in the problems tab is invalid

Describe the solution you'd like
The Apex PMD extension should prioritize the URL provided in the externalInfoUrl, available on the ruleset schema

Additional context
In the current version the url is hard-coded, see ApexPmd.ts#L241

const uri = `https://pmd.github.io/latest/pmd_rules_apex_${result.ruleSet
.split(' ')
.join('')
.toLowerCase()}.html#${result.rule.toLowerCase()}`;

@nicolas1bruno nicolas1bruno changed the title Inválido URL for custom files Invalid URL for custom files Apr 15, 2024
@NickTracker
Copy link

I also have this need, thanks for opening

@nicolas1bruno nicolas1bruno changed the title Invalid URL for custom files Invalid URL for custom rules Apr 20, 2024
@adangel adangel changed the title Invalid URL for custom rules Use externalInfoUrl for custom rules Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants