Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_tests: env vars are case sensitive #1447

Open
kolbma opened this issue Jan 30, 2025 · 0 comments
Open

unit_tests: env vars are case sensitive #1447

kolbma opened this issue Jan 30, 2025 · 0 comments

Comments

@kolbma
Copy link
Contributor

kolbma commented Jan 30, 2025

Next to my pull request #1446 for the SRCDIR variable, I've seen another env var:

const char *s = getenv("unrar_disabled");

https://github.com/kolbma/clamav-devel/blob/86a38352182aef4b63fcbd69fade4ac11b66bea2/unit_tests/check_clamav.c#L541

I don't need this flag, but I'm pretty sure this needs to be at least upper case, too.
But what I see, the check might be correctly on inverted ENABLE_UNRAR variable, because I don't think unrar_disabled would be set anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant