-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor_change] Added new module for Node Profile. (DCNE-139) #614
base: master
Are you sure you want to change the base?
Conversation
6acdea6
to
7e6f675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ysical_interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
type: str | ||
node_setting: | ||
description: | ||
- The Node Setting to associate with the Node Profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change to lower case?
- The node setting to associate with the Node Profile.
suboptions: | ||
name: | ||
description: | ||
- The name of the Node Setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change to lower case?
- The name of the node setting.
required: true | ||
template: | ||
description: | ||
- The name of the Fabric Policy template that contains the Node Setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change to lower case?
- The name of the Fabric Policy template that contains the node setting.
["state", "present", ["nodes"]], | ||
], | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add mutually_exclusive for ["node_setting_uuid", "node_setting"]?
nodes: | ||
description: | ||
- The list of node IDs to associate with the Node Profile. | ||
- Each element can either be a single node ID or a range of IDs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Each element can either be a single node ID or a range of IDs in quotation marks ('')
elements: str | ||
node_setting_uuid: | ||
description: | ||
- The UUID of the Node Setting to associate with the Node Profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The UUID of the node setting to associate with the Node Profile.
Fixes #468
Also adds support for node ID ranges in ndo_physical_interface.