Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] Added new module for Node Profile. (DCNE-139) #614

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Feb 24, 2025

Fixes #468

Also adds support for node ID ranges in ndo_physical_interface.

@samiib samiib self-assigned this Feb 24, 2025
@github-actions github-actions bot changed the title [minor_change] Added new module for Node Profile. [minor_change] Added new module for Node Profile. (DCNE-139) Feb 24, 2025
@samiib samiib force-pushed the node_profile branch 2 times, most recently from 6acdea6 to 7e6f675 Compare February 24, 2025 11:08
@samiib samiib marked this pull request as ready for review February 24, 2025 11:33
akinross
akinross previously approved these changes Feb 25, 2025
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

type: str
node_setting:
description:
- The Node Setting to associate with the Node Profile.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change to lower case?

  • The node setting to associate with the Node Profile.

suboptions:
name:
description:
- The name of the Node Setting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change to lower case?

  • The name of the node setting.

required: true
template:
description:
- The name of the Fabric Policy template that contains the Node Setting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change to lower case?

  • The name of the Fabric Policy template that contains the node setting.

["state", "present", ["nodes"]],
],
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add mutually_exclusive for ["node_setting_uuid", "node_setting"]?

nodes:
description:
- The list of node IDs to associate with the Node Profile.
- Each element can either be a single node ID or a range of IDs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Each element can either be a single node ID or a range of IDs in quotation marks ('')

elements: str
node_setting_uuid:
description:
- The UUID of the Node Setting to associate with the Node Profile.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The UUID of the node setting to associate with the Node Profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for Node Profile in Fabric Resource Policies Template (DCNE-139)
3 participants