Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Add resource and datasource for mso_template (DCNE-217) #309

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[minor_change] Add resource and datasource for mso_template (DCNE-217) #309

wants to merge 3 commits into from

Conversation

akinross
Copy link
Collaborator

No description provided.

@akinross akinross force-pushed the ndo_template branch 4 times, most recently from f5ea90c to 322cd71 Compare October 23, 2024 14:13
@akinross akinross added the jira-sync Sync this issue to Jira label Oct 23, 2024
@github-actions github-actions bot changed the title [minor_change] Add resource and datasource for mso_template [minor_change] Add resource and datasource for mso_template (DCNE-217) Oct 23, 2024
@akinross akinross force-pushed the ndo_template branch 3 times, most recently from 5a508bb to 3359905 Compare October 28, 2024 13:32
@akinross akinross force-pushed the ndo_template branch 3 times, most recently from 73f2ddc to 5ea9e9a Compare November 5, 2024 11:20
@akinross akinross force-pushed the ndo_template branch 2 times, most recently from 60ddd00 to 3046569 Compare November 6, 2024 08:32
sajagana
sajagana requested changes Nov 11, 2024
View reviewed changes
mso/resource_mso_template.go Outdated Show resolved Hide resolved
mso/resource_mso_template.go Outdated Show resolved Hide resolved
mso/resource_mso_template.go Outdated Show resolved Hide resolved
sajagana
sajagana previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot requested changes Nov 20, 2024
View reviewed changes
mso/resource_mso_template.go Outdated Show resolved Hide resolved
mso/resource_mso_template.go Outdated Show resolved Hide resolved
mso/resource_mso_template.go Outdated Show resolved Hide resolved
mso/resource_mso_template.go Outdated Show resolved Hide resolved
mso/resource_mso_template.go Outdated Show resolved Hide resolved
@akinross
[ignore] Change function SetToSchema to SetSchemaResourceData to bett…
a878bcc 
…er describe the functionality and adjust error messages
@akinross akinross dismissed stale reviews from gmicol, shrsr, and sajagana via a878bcc November 20, 2024 17:17
gmicol
gmicol approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I created DCNE-261 for the CI.

@akinross
Copy link
Collaborator Author

LGTM I created DCNE-261 for the CI.

perfect thanks!

sajagana
sajagana approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@akinross @lhercot @shrsr @anvitha-jain @sajagana @samiib @gmicol