From eaab435f6471e36e6c2c91fd09e3e8116edc3fc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20Kalij=C3=A4rvi?= Date: Fri, 2 Feb 2024 11:13:19 +0200 Subject: [PATCH 1/2] Changed the text for the visual regression error text. --- .github/workflows/visual.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/visual.yml b/.github/workflows/visual.yml index 8208eb7a5..43f3908cb 100644 --- a/.github/workflows/visual.yml +++ b/.github/workflows/visual.yml @@ -117,7 +117,7 @@ jobs: if: github.ref != 'refs/heads/main' run: | if ! npm run full-test; then - echo "result=❌ Tests failed!" >> $GITHUB_OUTPUT + echo "result=:warning: Visual regression found! Please check if this change is wanted or accidental at:" >> $GITHUB_OUTPUT else echo "result=✅ Tests passed!" >> $GITHUB_OUTPUT fi @@ -153,4 +153,3 @@ jobs: name: container-log path: /tmp/container.log retention-days: 1 - From 789b7123f51a2c5589c2e28be3c28515f0e6eabb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20Kalij=C3=A4rvi?= Date: Fri, 2 Feb 2024 12:00:32 +0200 Subject: [PATCH 2/2] Changed the warning messaged slightly. --- .github/workflows/visual.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/visual.yml b/.github/workflows/visual.yml index 43f3908cb..fd48ede5b 100644 --- a/.github/workflows/visual.yml +++ b/.github/workflows/visual.yml @@ -117,7 +117,7 @@ jobs: if: github.ref != 'refs/heads/main' run: | if ! npm run full-test; then - echo "result=:warning: Visual regression found! Please check if this change is wanted or accidental at:" >> $GITHUB_OUTPUT + echo "result=:warning: Visual regression found! Please check if this change is wanted or accidental. " >> $GITHUB_OUTPUT else echo "result=✅ Tests passed!" >> $GITHUB_OUTPUT fi