Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10772: Extend linkedevents app #1131

Merged
merged 6 commits into from
Dec 12, 2024
Merged

UHF-10772: Extend linkedevents app #1131

merged 6 commits into from
Dec 12, 2024

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Dec 10, 2024 •
edited by jira bot
Loading

UHF-10772

Extend linkedevents app

What was done

  • Add new config variables
  • Add card ghost
  • Add loading animation
  • Add bordered card variation

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Etusivu

@jeremysteerio jeremysteerio mentioned this pull request Dec 10, 2024
Merged
3 tasks
@jeremysteerio jeremysteerio marked this pull request as ready for review December 10, 2024 08:27
@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1131/html_report/

@jeremysteerio
Extend linkedevents app
258b115 
* Add new config variables
* Add card ghost
* Add loading animation
* Add bordered card variation
@jeremysteerio
Set fallback for image placeholders
244f633
@jeremysteerio
Coordinates-based event list improvements
7acf618 
* Fix double scrolling on page change
* Hide card ghosts behind drupalSettings setting
@jeremysteerio
Remove bordered card style
193ca99
@jeremysteerio
Use bordered styles for coordinates-based event list only
cdea9b4
@github-actions GitHub Actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1131/html_report/

teroelonen
teroelonen approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go 🦖

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1131/html_report/

@jeremysteerio jeremysteerio merged commit d35f85e into main Dec 12, 2024
2 checks passed
@jeremysteerio jeremysteerio deleted the UHF-10772 branch December 12, 2024 07:31
This was referenced Dec 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremysteerio @teroelonen