-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8081: Add sentry to react apps #765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error components.
This was referenced Sep 8, 2023
rpnykanen
approved these changes
Sep 11, 2023
This was referenced Sep 11, 2023
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8081
What was done
REACT_APP_
ENVsHow to install
UHF-8081-add-sentry-to-react-apps
branch.git pull origin UHF-8081-add-sentry-to-react-apps
make fresh
composer require drupal/hdbt:dev-UHF-8081-add-sentry-to-react-apps
composer require drupal/helfi_platform_config:dev-UHF-8081-add-sentry-to-react-apps
SENTRY_DSN_REACT=
with value to root.env
file. Get the right value e.g. from Azure rekry testing: https://dev.azure.com/City-of-Helsinki/helfi-rekry/_library?itemType=VariableGroups&view=VariableGroupView&variableGroupId=2469&path=drupal-testingSENTRY_DSN_REACT=${SENTRY_DSN_REACT}
todocker-compose.override.yml
belowELASTIC_PROXY_URL
make up
make shell
andprintenv
you should seeSENTRY_DSN_REACT
with valuedrush cr
How to test
make ps
to check the instances Elastic container name e.g.helfi-kymp-elastic
. Rundocker stop helfi-kymp-elastic
https://helfi-kymp.docker.so/fi/kaupunkiymparisto-ja-liikenne/kaupunkisuunnittelu-ja-rakentaminen/hae-suunnitelmia-ja-hankkeita
https://helfi-rekry.docker.so/fi/avoimet-tyopaikat/etsi-avoimia-tyopaikkoja
https://helfi-etusivu.docker.so/fi/uutiset
https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus
You have to create a Landing Page with School Search paragraph
Other PRs