Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Modified the unit services component title to be translated with a context and added a translation #792

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 5, 2023

What was done

  • Modified the unit services component title to be translated with a context and added a translation

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_unit_services_title_translation
  • Run make drush-cr
  • Run make shell
  • In the shell drush locale:check; drush locale:update; drush cr

How to test

  • Go to any unit page that is in Swedish and has services. The page should now have the title translated to "Tjänster".
  • Check also that the Finnish version of this same block is "Palvelut"
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good catch! 🚀

…into UHF-X_unit_services_title_translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants