KAAV-2046 add fixes for SonarCloud Quality Gate problems,more PropTyp…

…es fixes
City-of-Helsinki · Sep 30, 2024 · dadb6a2 · dadb6a2
1 parent 9468845
commit dadb6a2
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 18 deletions.
diff --git a/src/components/input/CustomField.js b/src/components/input/CustomField.js
@@ -811,14 +811,14 @@ class CustomField extends Component {
 
 CustomField.propTypes = {
   disabled: PropTypes.bool,
-  field:PropTypes.object,
-  input:PropTypes.func,
-  onRadioChange:PropTypes.func,
-  defaultValue:PropTypes.bool,
-  formName:PropTypes.string,
-  attributeData:PropTypes.object,
-  deadlines:PropTypes.array,
-  isProjectTimetableEdit:PropTypes.bool,
+  field: PropTypes.object,
+  input: PropTypes.func,
+  onRadioChange: PropTypes.func,
+  defaultValue: PropTypes.bool,
+  formName: PropTypes.string,
+  attributeData: PropTypes.object,
+  deadlines: PropTypes.array,
+  isProjectTimetableEdit: PropTypes.bool,
   nonEditable: PropTypes.bool,
   rollingInfo: PropTypes.bool,
   modifyText: PropTypes.string,
@@ -838,11 +838,27 @@ CustomField.propTypes = {
     PropTypes.bool,
     PropTypes.object
   ]),
-  isCurrentPhase:PropTypes.bool,
+  isCurrentPhase: PropTypes.bool,
   selectedPhase: PropTypes.number,
   phaseIsClosed: PropTypes.bool,
   checkLocked: PropTypes.func,
-  isTabActive: PropTypes.bool
-}
+  isTabActive: PropTypes.bool,
+  disabledDates: PropTypes.array,
+  lomapaivat: PropTypes.array,
+  dateTypes: PropTypes.object,
+  deadlineSection: PropTypes.object,
+  maxMoveGroup: PropTypes.object,
+  maxDateToMove: PropTypes.string,
+  groupName: PropTypes.string,
+  visItems: PropTypes.array,
+  visGroups: PropTypes.array,
+  deadlineSections: PropTypes.array,
+  formValues: PropTypes.object,
+  confirmedValue: PropTypes.oneOfType([
+    PropTypes.string,
+    PropTypes.number,
+    PropTypes.bool,
+  ])
+};
 
 export default CustomField
diff --git a/src/components/input/DeadlineInfoText.js b/src/components/input/DeadlineInfoText.js
@@ -112,8 +112,10 @@ DeadlineInfoText.propTypes = {
       PropTypes.string,
       PropTypes.number,
       PropTypes.bool,
-    ])
-  })
+    ]),
+    name: PropTypes.string,
+  }),
+  label: PropTypes.string,
 }
 
 export default DeadlineInfoText
diff --git a/src/components/input/DeadlineInput.js b/src/components/input/DeadlineInput.js
@@ -414,7 +414,10 @@ DeadLineInput.propTypes = {
   timeTableDisabled: PropTypes.bool,
   dateTypes: PropTypes.object,
   deadlineSection: PropTypes.object,
-  maxMoveGroup: PropTypes.object,
+  maxMoveGroup: PropTypes.oneOfType([
+    PropTypes.object,
+    PropTypes.string
+  ]),
   maxDateToMove: PropTypes.string,
   groupName: PropTypes.string,
   visGroups: PropTypes.array,

diff --git a/src/components/input/FormField.js b/src/components/input/FormField.js
@@ -352,7 +352,10 @@ FormField.propTypes = {
   lomapaivat: PropTypes.array,
   dateTypes: PropTypes.object,
   deadlineSection: PropTypes.object,
-  maxMoveGroup: PropTypes.object,
+  maxMoveGroup: PropTypes.oneOfType([
+    PropTypes.object,
+    PropTypes.string
+  ]),
   maxDateToMove: PropTypes.string,
   groupName: PropTypes.string,
   visGroups: PropTypes.array,

diff --git a/src/components/projectEdit/index.js b/src/components/projectEdit/index.js
@@ -806,9 +806,6 @@ ProjectEditPage.propTypes = {
   showTimetableForm: PropTypes.bool,
   attribute_data: PropTypes.object,
   saveProjectFloorArea: PropTypes.func,
-  isResponsible: PropTypes.bool,
-  projectPhaseIndex: PropTypes.number,
-  isAdmin: PropTypes.bool,
 }
 
 const mapStateToProps = state => {