Palvelukokonaisuudet (Service Units) #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NC-jsAhonen
changed the title
NC-jsAhonen
requested review from
a user,
henrinie-nc and
EmiliaMakelaVincit
and removed request for
a user
ghost
previously requested changes
Oct 16, 2023
There was a problem hiding this comment.
Initial findings commented to the pull request and there are some ideas written how to improve code quality. Lets discuss about changes also on a meeting. Shortly mentioned there are so many changes in this pull request that review will take a bit too long -> smaller changes, easier to check them.
NC-jsAhonen
dismissed
ghost
’s stale review
Looked through the suggestions under this comment
ghost
suggested changes
Nov 8, 2023
ghost
approved these changes
Nov 22, 2023
ghost
approved these changes
Dec 15, 2023
NC-jsAhonen
force-pushed
the
service-units-2
branch
from
f0a2d18 to
a1bb88d
Compare
ghost
approved these changes
Jan 9, 2024
ghost
approved these changes
Jan 10, 2024
NC-jsAhonen
force-pushed
the
service-units-2
branch
from
6355d15 to
dd5b386
Compare
ghost
reviewed
Mar 11, 2024
| @@ -365,6 +370,11 @@ class AreaSearchApplicationListPage extends PureComponent<Props, State> { | |||
| } | |||
|
|
|||
| searchQuery.limit = LIST_TABLE_PAGE_SIZE; | |||
|
|
|||
| if (searchQuery.service_unit === undefined && userActiveServiceUnit) { | |||
There was a problem hiding this comment.
In Abstract there are 3 tabs (own work, own unit's work, and all area searches). Does this functionality allow user to see all area searches from all service units by default?
NC-jsAhonen
force-pushed
the
service-units-2
branch
from
96ca504 to
1d46695
Compare
NC-jsAhonen
force-pushed
the
service-units-2
branch
from
1d46695 to
b9907c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tässä haarassa toteutetaan palvelukokonaisuudet ja se on tuotu viimeisimpien muutosten tasalle.
Tämä haara on duplikaatti haarasta service units ja PR:stä #401 , koska rebasen tehtyäni lokaalin ja remoten committien historiatiedoissa oli jotain ristiriitaa, niin päätin tehdä uuden haaran.
Bäkkärin vastaava branch on
wip-service-unit.