Plot search form validations #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields that will be validated with special validators are: - Personal identifier (henkilotunnus) - Company identifier (y-tunnus) - Email (sahkoposti) - Control shares (hallintaosuus), evaluated across the entire form for all applicants Any field whose identifier matches the one specified above will automatically get the relevant validator applied to it.
- Disable past dates - Allow selecting the same date for both start and end - Allow omitting the end date
| return error || 'Virheellinen henkilötunnus'; | ||
| } | ||
|
|
||
| const result = /^(\d{6})([-+ABCDEFUVWXY])(\d{3})([0-9ABCDEFHJKLMNPRSTUVWXY])$/.exec(value.toUpperCase()); |
There was a problem hiding this comment.
I just realised, that backend does not have this touppercase -operation and therefore this could pass the ui validation but fail at the be-side.
There was a problem hiding this comment.
FieldRegexValidator(
"^[0-9]{6}[+Aa-][0-9]{3}[A-z0-9]$", "invalid_ssn", "henkilotunnus"
),To me it does seem it accepts both uppercase and lowercase characters... though incorrectly (A-z includes these characters besides the intended letters: [\]^_`). That set by itself is a bit too wide as letters like Q never appear as the check character, though. It also doesn't seem to accept the recently added additional separator characters.
Right, the actual validation in answer.py does the actual math properly, and indeed doesn't accept lowercase characters. The separator problem remains in the regex, however.
PasiVuohijoki
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validators for select application form fields, and also fixes some area search specs page validations that were fixed on the public side earlier.