Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9606 decisionmakers #43

Merged
merged 35 commits into from
Mar 28, 2024
Merged

UHF-9606 decisionmakers #43

merged 35 commits into from
Mar 28, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Mar 8, 2024 •
edited
Loading

UHF-9606

run NODE_OPTIONS=--openssl-legacy-provider npm start

How to test

After the elasticsearch index has been updated

  • Check that the searches work as described in the ticket.

Other PRs

City-of-Helsinki/helsinki-paatokset#388

rpnykanen and others added 27 commits December 8, 2023 07:37
@rpnykanen
add a version to nvmrc which allows installing packages
ee168a0
@rpnykanen
full width keyword search bar and submit button under search fields a…
61f6032 
…lso on desktop
@rpnykanen
more submit button changes
5dc2b65
@rpnykanen
working multiselect combobox
1dcd591
@rpnykanen
added decisionmakers to the dropdown, map the id with name
4d1c1f0
@rpnykanen
properly set the data
684b24b
@rpnykanen
Merge branch 'develop' into UHF-8859
457ce18
@rpnykanen
updated form container and dm select combobox
ef835a2
@rpnykanen @juho-lehmonen
add a version to nvmrc which allows installing packages
c339c83
@rpnykanen @juho-lehmonen
full width keyword search bar and submit button under search fields a…
0977a0e 
…lso on desktop
@rpnykanen @juho-lehmonen
more submit button changes
eca3db6
@rpnykanen @juho-lehmonen
working multiselect combobox
b6ae70d
@rpnykanen @juho-lehmonen
added decisionmakers to the dropdown, map the id with name
50c376f
@rpnykanen @juho-lehmonen
properly set the data
49c7dd1
@rpnykanen @juho-lehmonen
updated form container and dm select combobox
294454c
@rpnykanen
Merge branch 'UHF-8859' of github.com:City-of-Helsinki/paatokset-sear…
a478e86 
…ch into UHF-8859
@rpnykanen
Added reducer to filter duplicate entries from the list. Added types …
5ab10be 
…for aggregate and combobox-item. Fixed bug which caused all items to be added to query-parameter
@rpnykanen
added ID to all duplicate dropdown labels
706f0f0
@rpnykanen
sectors and special cases works
1e23327
@rpnykanen
sectors id to label from queryparameters
1d7cecc
@rpnykanen
sector search
d0bacd0
@rpnykanen
Merge remote-tracking branch 'origin/UHF-8859' into UHF-9606_decision…
2c5db26 
…makers
@rpnykanen
update set up instructions
31f86cb
@rpnykanen
policymaker search, exclude if policymaker_existing is false
0afb7a4
@rpnykanen
removed two hardcoded dms and added sector data to dm dropdown title
e27ddd0
@rpnykanen
remove commented code
cabc69e
@rpnykanen
unused import
72362b0
@rpnykanen rpnykanen mentioned this pull request Mar 8, 2024
Merged
@juho-lehmonen juho-lehmonen self-requested a review March 8, 2024 09:15
juho-lehmonen
juho-lehmonen suggested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include the fix on policymaker search to exclude non existing policymakers from the results?

@juho-lehmonen juho-lehmonen merged commit 15ee0cc into develop Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juho-lehmonen juho-lehmonen juho-lehmonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpnykanen @juho-lehmonen