Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different reinforcement materials have different warm up times. #20

Open
dbear20 opened this issue Jun 29, 2015 · 8 comments
Open

Different reinforcement materials have different warm up times. #20

dbear20 opened this issue Jun 29, 2015 · 8 comments

Comments

@dbear20
Copy link

dbear20 commented Jun 29, 2015

Suggestion was made here https://forum.civcraft.co/t/suggestion-make-stone-iron-reinforced-bastions-mature-faster/568 that different reinforcement materials should,have different warm up times. Bastion will need code added to get the reinforcement material and apply the correct warm up time from the bastion config.

@rourke750
Copy link

What would the point of this be? It doesnt matter what reinforcement you use on a bastion when placing blocks it will take the same amount of block breaks.

@dbear20
Copy link
Author

dbear20 commented Jun 29, 2015

Maybe also make the lower reinforcements require less block placement?

@ttk2
Copy link

ttk2 commented Jun 29, 2015

I thought the required block breaks was based on the reinforcement? Each
successful place wears down the reinforcement value.

Or maybe it started with that principle and ended up being separate. I can
see how that would be easier.

On Mon, Jun 29, 2015, 6:03 AM dbear20 [email protected] wrote:

Maybe also make the lower reinforcements require less block placement?


Reply to this email directly or view it on GitHub
#20 (comment).

@rourke750
Copy link

@ttk2 No it all breaks by a percent of the max reinforcement each time a block is placed. That is why the config option is defined like this.

@ttk2
Copy link

ttk2 commented Jun 29, 2015

ok then, that explains my confusion thanks.

@jjj5311
Copy link

jjj5311 commented Jul 1, 2015

I think different reinforcements should have different warm up times?

how does that work... what is the benefit of using diamond to reinforce bastion vs sponge? Does the scalfing factor scaler based on the reinforcement or no?

@ttk2
Copy link

ttk2 commented Jul 1, 2015

no its not, I thought it was since Citadel has that concept, but it looks like maturation time for a bastion is decoupled from the reinforcement maturation time.

@spaceFountain
Copy link

Actually sorry I didn't see this earlier, but it was while I was away on vacation. I was just really bad at naming. @ttk2 was right and both those values are the amount of reinforcement that should be removed when a block is placed at the start of the warmup time and at the end. They are not a fraction of the total strength. I added code to allow for storing in my own db fractional reinforcement values. Here's the function that actually removes the reinforcement and here is the function that calculates how much to remove

Maxopoly pushed a commit to Maxopoly/Bastion that referenced this issue Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants