-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different reinforcement materials have different warm up times. #20
Comments
What would the point of this be? It doesnt matter what reinforcement you use on a bastion when placing blocks it will take the same amount of block breaks. |
Maybe also make the lower reinforcements require less block placement? |
I thought the required block breaks was based on the reinforcement? Each Or maybe it started with that principle and ended up being separate. I can On Mon, Jun 29, 2015, 6:03 AM dbear20 [email protected] wrote:
|
@ttk2 No it all breaks by a percent of the max reinforcement each time a block is placed. That is why the config option is defined like this. |
ok then, that explains my confusion thanks. |
I think different reinforcements should have different warm up times? how does that work... what is the benefit of using diamond to reinforce bastion vs sponge? Does the scalfing factor scaler based on the reinforcement or no? |
no its not, I thought it was since Citadel has that concept, but it looks like maturation time for a bastion is decoupled from the reinforcement maturation time. |
Actually sorry I didn't see this earlier, but it was while I was away on vacation. I was just really bad at naming. @ttk2 was right and both those values are the amount of reinforcement that should be removed when a block is placed at the start of the warmup time and at the end. They are not a fraction of the total strength. I added code to allow for storing in my own db fractional reinforcement values. Here's the function that actually removes the reinforcement and here is the function that calculates how much to remove |
Fixed db issues on startup
Suggestion was made here https://forum.civcraft.co/t/suggestion-make-stone-iron-reinforced-bastions-mature-faster/568 that different reinforcement materials should,have different warm up times. Bastion will need code added to get the reinforcement material and apply the correct warm up time from the bastion config.
The text was updated successfully, but these errors were encountered: