forked from Bergecraft/CivModCore
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config stuff breaks default bukkit config #13
Labels
Comments
Any objection to just gutting this and using the annotations to wire up a Bukkit-standard "default config" behind the scenes, which gets overridden by package config which gets overridden by plugin-folder config (e.g. like normal)? |
Not from my side |
I'll just assume no objection b/c it should be transparent to any plugin that utilizes this. I'll get on it. |
Maxopoly
pushed a commit
to Maxopoly/CivModCore
that referenced
this issue
Oct 31, 2016
Use Devoted jenkins
Maxopoly
added a commit
to Maxopoly/CivModCore
that referenced
this issue
Apr 29, 2020
refactoring and minor improvements
Maxopoly
pushed a commit
to Maxopoly/CivModCore
that referenced
this issue
Mar 14, 2022
Move sonarqube to root project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saveDefaultConfig should just fail silently, but with CivModCore it will always save the yml structure back, which means it actively removes comments, formatting etc. Also if the file is not parsed properly it will sometimes delete the whole config.
It seems like additionally it's not saving the normal default config if no config exists previously (when starting plugin for first time).
The text was updated successfully, but these errors were encountered: