-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/ppf should spawn the player in the overworld where they were freed if they were online when freed. #149
Comments
What currently happens?
|
they are killed and random spawn. |
Let me actually try this again on a local server. It is possible the event I am referring to was caused because the player was already in death screen when freed. |
Did you check the config? I think that's a config option.
|
Yes it is set to true. Also I think teleporting the player to the end shard is broken in sharded servers as well. I couldn't get it to work locally. Both the server name and the world were set in the config. I think the problem is here: https://github.com/Civcraft/PrisonPearl/blob/master/src/vg/civcraft/mc/prisonpearl/managers/PrisonPearlManager.java#L345 This method should return a random location to spawn a player in the prison world but it looks like it will just give a random location that can be everywhere. |
It always worked when I tested it. I'll look I to this again. also for the
config option shouldn't it be false.
|
it is named free_tppearl so I don't think so. |
Also some of the code was changed in this commit: f8dadfe I don't think any testing was done on a sharded server after this commit. |
@BlackXnt nothing changed in that commit that would impact Sharded servers. Most of the changes in that specific commit where whitespace fixes. The additional spawning logic is for non-sharded servers only (note that if sharding is enabled, the new code added isn't run at all). Etc. |
Is this still occurring? |
No description provided.
The text was updated successfully, but these errors were encountered: