Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/ppf should spawn the player in the overworld where they were freed if they were online when freed. #149

Open
idoash4 opened this issue Jul 11, 2016 · 10 comments

Comments

@idoash4
Copy link

idoash4 commented Jul 11, 2016

No description provided.

@rourke750
Copy link

rourke750 commented Jul 11, 2016 via email

@idoash4
Copy link
Author

idoash4 commented Jul 11, 2016

they are killed and random spawn.

@idoash4
Copy link
Author

idoash4 commented Jul 11, 2016

Let me actually try this again on a local server. It is possible the event I am referring to was caused because the player was already in death screen when freed.

@rourke750
Copy link

rourke750 commented Jul 11, 2016 via email

@idoash4
Copy link
Author

idoash4 commented Jul 11, 2016

Yes it is set to true.

Also I think teleporting the player to the end shard is broken in sharded servers as well. I couldn't get it to work locally. Both the server name and the world were set in the config. I think the problem is here: https://github.com/Civcraft/PrisonPearl/blob/master/src/vg/civcraft/mc/prisonpearl/managers/PrisonPearlManager.java#L345

This method should return a random location to spawn a player in the prison world but it looks like it will just give a random location that can be everywhere.

@rourke750
Copy link

rourke750 commented Jul 11, 2016 via email

@idoash4
Copy link
Author

idoash4 commented Jul 11, 2016

it is named free_tppearl so I don't think so.

@idoash4
Copy link
Author

idoash4 commented Jul 11, 2016

Also some of the code was changed in this commit: f8dadfe

I don't think any testing was done on a sharded server after this commit.

@ProgrammerDan
Copy link

@BlackXnt nothing changed in that commit that would impact Sharded servers. Most of the changes in that specific commit where whitespace fixes.

The additional spawning logic is for non-sharded servers only (note that if sharding is enabled, the new code added isn't run at all). Etc.

@rourke750
Copy link

Is this still occurring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants