Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n tags to all Django templates #876

Open
brylie opened this issue May 14, 2021 · 11 comments
Open

Add i18n tags to all Django templates #876

brylie opened this issue May 14, 2021 · 11 comments
Labels
code quality enhancement mentoring Issues that need active mentoring.
Milestone

Comments

@brylie
Copy link
Member

brylie commented May 14, 2021

As we port templates from the SPA app over to regular Django templates, ensure that we add localization support for all static texts. Prior to the 2.0 release, review all templates to make sure the internationalization is complete.

@mharyam
Copy link
Contributor

mharyam commented Aug 20, 2021

Hello @brylie,
Can I take this?

@brylie
Copy link
Member Author

brylie commented Aug 20, 2021

@mharyam yes please :-) I'll assign you to the issue. Please let us know how we can be of assistance.

@brylie brylie added the mentoring Issues that need active mentoring. label Aug 20, 2021
@mharyam
Copy link
Contributor

mharyam commented Aug 20, 2021

Thank you, I will.

@mharyam
Copy link
Contributor

mharyam commented Aug 23, 2021

Hello @brylie,

For this task, do you think it is ideal I add template tag {%trans%} to all the individual templates?

@brylie
Copy link
Member Author

brylie commented Aug 24, 2021

@mharyam, yes. Follow the guidelines from Django documentation.

@mharyam
Copy link
Contributor

mharyam commented Aug 27, 2021

Hello @brylie
I have created my first pull request for this task
Link: #976

I added translation to the landing page, header and footer
If it is fine, I will proceed to the next one

Thank you.

@mharyam mharyam mentioned this issue Aug 28, 2021
@brylie
Copy link
Member Author

brylie commented Aug 30, 2021

Thank you so much @mharyam! 😃

I've reviewed your pull request and made some minor suggestions with code changes that you can automatically accept.

@mharyam
Copy link
Contributor

mharyam commented Aug 30, 2021

Hello @brylie

Thanks a lot for taking out time to review! I have accepted all the suggestions.

It looks like you still need to merge the pull request, so it can be updated to the main branch

Thank you.

@mharyam
Copy link
Contributor

mharyam commented Aug 31, 2021

Thank you @brylie for taking out time to approve the pull request.

Do you think there are other pages I need to add translation to?

@brylie
Copy link
Member Author

brylie commented Sep 1, 2021

Basically, just look for a templates subfolder in any of the Django app folders. For example, there are several accounts-related templates that need i18n tags.

brylie added a commit that referenced this issue Sep 4, 2021
@rsk2
Copy link

rsk2 commented Nov 23, 2023

Hi @brylie, I'd like to help with this issue. Please let me know if there is any work that still needs to be done for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement mentoring Issues that need active mentoring.
Projects
None yet
Development

No branches or pull requests

3 participants