Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cwd configuration #279

Open
rgzntrade opened this issue Nov 26, 2024 · 8 comments
Open

Invalid cwd configuration #279

rgzntrade opened this issue Nov 26, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@rgzntrade
Copy link

Replication:

  1. executable path: /a/debug/exe
  2. cwd path: /a
  3. config path: /a/config
    CMakeRun
    Status: cd /a/debug/ && .exe, can't use /a/config
    Expected: . /a/debug/exe, can use /a/config
@rgzntrade rgzntrade added the bug Something isn't working label Nov 26, 2024
@rgzntrade
Copy link
Author

Should be like std::filesystem::current_path(argv[1]);, but not directly using std::filesystem::current_path(argv[1]);.

@rgzntrade
Copy link
Author

By the way one should not create both buffer and terminal at the same time, one can create the terminal in the buffer. This way you don't have to create a window and the viewing area is bigger.

@lceWolf
Copy link
Collaborator

lceWolf commented Jan 9, 2025

I think #276 should have fixed the issue. Can you please check again?

@lceWolf
Copy link
Collaborator

lceWolf commented Jan 9, 2025

By the way one should not create both buffer and terminal at the same time, one can create the terminal in the buffer. This way you don't have to create a window and the viewing area is bigger.

What are you referring to?

@rgzntrade
Copy link
Author

rgzntrade commented Jan 10, 2025

I think #276 should have fixed the issue. Can you please check again?

I tried to modify the working_dir in base settings is working. “cwd” = ‘xxx’ is not working.

I found another problem TargetSettings overrides CmakeSettings.
Reproduce the steps:

  1. CmakeSettings
  2. CmakeTargetSettings
  3. CmakeSettings
    The third one is different from the first CmakeSettings and the same as the second CmakeTargetSettings.
    Expect
    The first CmakeSettings and the third CmakeSettings have the same results

@rgzntrade
Copy link
Author

By the way one should not create both buffer and terminal at the same time, one can create the terminal in the buffer. This way you don't have to create a window and the viewing area is bigger.

What are you referring to?

I want the CMakeRun window to be closed by q or esc, not ctrl-w q

@lceWolf
Copy link
Collaborator

lceWolf commented Jan 10, 2025

I think #276 should have fixed the issue. Can you please check again?

I tried to modify the working_dir in base settings is working. “cwd” = ‘xxx’ is not working.

I found another problem TargetSettings overrides CmakeSettings. Reproduce the steps:

1. CmakeSettings

2. CmakeTargetSettings

3. CmakeSettings
   The third one is different from the first CmakeSettings and the same as the second CmakeTargetSettings.
   Expect
   The first CmakeSettings and the third CmakeSettings have the same results

I actually noticed this myself. Sometimes the directory is messed up. A CMakeSelectCwd fixed the issue for me tho.
Will investigate this eventually.

I want the CMakeRun window to be closed by q or esc, not ctrl-w q

The terminal's filetype is set to cmake_tools_terminal. You could e.g. create a ftplugin to add a keybind for closing it with q or esc.
Also there is the CMakeCloseRunner command

@lceWolf
Copy link
Collaborator

lceWolf commented Jan 20, 2025

@rgzntrade can you please close the issue, if you think it is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants