Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuthenticatorWindow in iOS 13 is displayed as pageSheet #105

Open
munkii opened this issue Dec 4, 2019 · 2 comments
Open

WebAuthenticatorWindow in iOS 13 is displayed as pageSheet #105

munkii opened this issue Dec 4, 2019 · 2 comments

Comments

@munkii
Copy link

munkii commented Dec 4, 2019

The WebAuthenticatorWindow that is used by WebAuthenticator from the FitBitApi provider does not allow the customisation of the ViewController or more specifically the ModalPresentationStyle.

In iOS 13 Apple changed the default presentation style for Modal views to be PageSheet from FullScreen. This affects the way Modal pages are dismissed and in Xamarin Forms that causes issues with ViewIsAppearing\ViewIsDisappearing events.

If the WebAuthenticatorWindow is dismissed by simply swiping down the Navigation Stack in XF becomes broken, the page now being is playing cannot be exited and the app needs restarting.

@Clancey
Copy link
Owner

Clancey commented Dec 5, 2019

You have complete control over presenting the UI https://github.com/Clancey/SimpleAuth#webview-authentication

@munkii
Copy link
Author

munkii commented Dec 5, 2019

Geez, despite wandering all over the the code in GitHub I could not see this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants