Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small problems with promotion dialog #168

Open
Epitomaniac opened this issue Oct 16, 2024 · 1 comment
Open

Two small problems with promotion dialog #168

Epitomaniac opened this issue Oct 16, 2024 · 1 comment

Comments

@Epitomaniac
Copy link
Contributor

First: The vertical dialog when it appears on the bottom rank should start from bottom to top so as not to pop outside of the board.
Second: When both sides have a pawn on the penultimate rank, both can bring out the promotion dialog regardless of who has the move; one possible fix is to only allow draggable for the side whose turn it is to move (following Lichess's example).

@Konstantin9658
Copy link

I'll even say more, you can call a dialogue even if your pawn move to the last square is not valid. Of course, after making such a move and choosing a piece, nothing happens, but it's strange to see this
screen-capture.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants