Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete journeymap #283

Closed
5 tasks done
xxhaze opened this issue Jan 15, 2025 · 35 comments
Closed
5 tasks done

Unable to delete journeymap #283

xxhaze opened this issue Jan 15, 2025 · 35 comments

Comments

@xxhaze
Copy link

xxhaze commented Jan 15, 2025

Your CleanroomMC Discord Username

hazeether

Cleanroom Version

0.2.4-alpha

Java Version

Java 21

Graphics Card Vendor

AMD/ATI

Bug Report

When trying to delete a previous map from another world, appears following error: "Unable to delete Map. See journeymap.log". It seems, that the first time you created a world and try to delete the map of it it works. But once you create a new world, or join a server, occurs the error.

Here is the log of journeymap:

journeymap.log

Mod List

AE2 Stuff Unofficial
AE2 Unofficial Extended Life
AE2 Wireless Terminals (AE2WTLib)
ATM Tweaks Extended
AbyssalCraft
AbyssalCraft Integration
Actually Additions
Actually Baubles
Additional Banners
Advanced Generators
Advanced Rocketry
Akashic Tome
AngelRing 2 Bauble
AppleCore-mc1.12.2-3.4.0
AppleSkin
Armory Expansion
Aroma1997's Dimensional World
Aroma1997Core
Astral Sorcery
AutoRegLib
BD Lib
Bad Wither No Cookie! Reloaded
Baubles
Bed Patch
Better Advancements
Better Builder's Wands
Better Quest Pop-up
BetterFps-1.4.8
BiblioCraft
Binnie Core
Biomes O' Plenty
Blockcraftery
Blood Magic: Alchemical Wizardry
Bookshelf
Botania
Brandon's Core
CTM
Ceramics
Chameleon
Chisel
Chisels & Bits
CoFH Core
CoFH World
CodeChicken Lib
Colossal Chests
CommonCapabilities
Compact Machines 3
Compact Solar Arrays
ComputerCraft
Computronics
ConfigAnytime
Construct's Armory
Controlling
Cooking for Blockheads
CosmeticArmorReworked
CraftPresence
CraftTweaker2
Crafting Tweaks
Cucumber Library
Custom Backgrounds
Custom Main Menu
Cyclic
Cyclops Core
DE Fusion Crafting Recipe Changes
Dark Utilities
Default Options
Default World Generator
Ding
Doomlike Dungeons
Draconic Evolution
EXCore
Embers Unofficial Extended Life
Ender IO
EnderCore
EnderStorage
Environmental Tech
Extra Cells 2
Extra Rails
Extra Utilities 2
Extreme Reactors
FTB Backups
FTB Library
FTB Quests
FTB Utilities
Fairy Lights
Flat Colored Blocks
Forestry
Forge Multipart CBE
Fugue
Funky Locomotion
Game Stages
GenDustry
Guide-API
Guidebook
GunpowderLib
Had Enough Items
Immersive Engineering
Immersive Petroleum
Immersive Tech
Industrial Foregoing
Industrial Wires
IndustrialCraft 2
InitialInventory
Integrated Derivative
Integrated Dynamics
Integrated Tunnels
Integration Foregoing
Inventory Generators
Inventory Tweaks
Iron Backpacks
Iron Chest
Item Filters
JAOPCA
JEI Bees
JEI Integration
JourneyMap
Just Enough Dimensions
Just Enough Resources
KJ Lib
KleeSlabs
LibrarianLib
LoliASM
Lost Souls
LunatriusCore
MCMultiPart-2.5.3
MTLib
Magic Bees
Magical Psi
MalisisCore
MalisisDoors
Mantle
McJtyLib
Mekanism-CE-Unofficial-All-9.9.1.216
MineColonies
MixinBooter
Mob Totems
Mod Name Tooltip
Mod Tweaker
Modpack Config Checker
Modular Machinery: Community Edition
MoreOverlays
Morph-o-Tool
Morpheus
Mouse Tweaks Unofficial
MrTJPCore
Mystical Agradditions
Mystical Agriculture
Mystical Lib
Mystical World
Natura
Nature's Compass
No Mob Spawning on Trees
No Night Vision Flashing
Not Enough Wands
NotEnoughIDs
NuclearCraft
Nutrition
OpenBlocks
OpenComputers
OpenComputers Xnet Driver
OpenModsLib
OreExcavation
OreExcavation Integration
Overloaded
PackCrashInfo
Pam's Cookables
Pam's HarvestCraft
Patchouli
Pink Flamingo
Placebo
Plants
Platforms
PlusTiC
PneumaticCraft: Repressurized
PortalGun
Portality
Practical Logistics 2
Pressure Pipes
Project Intelligence
ProjectRed Compatibility
ProjectRed Core
ProjectRed Expansion
ProjectRed Exploration
ProjectRed Fabrication
ProjectRed Illumination
ProjectRed Transmission
Psi
QuantumStorage
Quark
RFTools
RFTools Control
RFTools Dimensions
RandomPatches
Ranged Pumps
ReAuth
Real Filing Cabinet
Reborn Core
RebornStorage
RecipeStages
Redstone Arsenal
Redstone Flux
Refined Storage
Reliquary
Resource Loader
Roots
Rustic
SBM-WoodenShears-1.12-0.0.1b8
Scalar
Schematica
Server Tab Info
ShadowMC
Shadowfacts' Forgelin
ShetiPhian-Core
Shield Parrying
Simply Jetpacks 2
SlimyBoyos
SonarCore
Soul Shards - The Old Ways
Stellar Core
Steve's Carts 2
Storage Drawers
Storage Drawers Extras
TOP Addons
Tech Reborn
TechReborn-ModCompatibility-1.12.2-1.4.0.76
Terraqueous
Tesla Core Lib
Thaumcrafft Inventory Scanning
Thaumcraft
ThaumicJEI
The Betweenlands
The Lost Cities
The One Probe
The Twilight Forest
Thermal Cultivation
Thermal Dynamics
Thermal Expansion
Thermal Foundation
Thermal Innovation
TickCentral-3.2
Tinker I/O
Tinkers Tool Leveling
Tinkers' Construct
Tomb Many Graves
TombManyGraves2 API
TotalDebug
TotalPerformance
Traverse
UniDict
UniLib
Universal Tweaks
Useful Nullifiers
Valkyrie Lib
VintageFix
Vintagium
WAIM-1.0.0
WanionLib
Water Strainer
Waystones
Wireless Crafting Terminal 2
WirelessCharger
Wizardry
Woot
WrapUp-1.12-1.1.3
XNet
Xtones
YNot
Zero CORE
careerbees-0.4.0
compatlayer
dl_overrides.py
flare-0.2.1
iChunUtil
libVulpes
override_mods.txt
p455w0rd's Library
packmode-1.12.2-1.2.0
rftoolspower-1.12-1.2.0

MMC Instance Notes

.

Final Checklist

  • I have searched the issues and haven't found a similar issue.
  • I have read the known incompatibilities and this is not related to one of those.
  • I have installed Fugue and it does not fix this issue.
  • I am using experimental branch and have installed Scalar and it does not fix this issue.
  • I am running a test build from Cleanroom Github Actions. (Or, if I've compiled it myself I plan to fix the issue)
@kappa-maintainer
Copy link
Collaborator

Caused by updating guava, please try latest action build of Fugue

@xxhaze
Copy link
Author

xxhaze commented Jan 16, 2025

I tried it again, with the latest action build of Fugue, didn't fix it.

journeymap.log

@kappa-maintainer
Copy link
Collaborator

Guess I should test it myself
How did you "delete a map"? Is there a command for this?

@xxhaze
Copy link
Author

xxhaze commented Jan 16, 2025

Open your map with J on the down side of the map you will see multiple symbol, pick the one that looks like a trash can. You will be able to delete the map of your current dimension and of all dimensions.

@G1ll0u
Copy link

G1ll0u commented Jan 16, 2025

You can delete the map by deleting minecraft/journeymap/data/(mp or sp)/worldname/DIM*

And btw, deleting map from in-game GUI works for me.

using the latest release 0.2.4a
modlist

@KorewaLidesu
Copy link
Collaborator

Can you provide a minimal reproduce step + latest log?

@xxhaze
Copy link
Author

xxhaze commented Jan 17, 2025

Apparently it seems easier to replicate the error via server.

Mods: journeymap-1.12.2-5.7.1p3, Fugue (the latest action build of yesterday) and scalar-1.12.2-2.11.1
cleanroom version: 0.2.4-alpha

  1. Create a new server and join it
  2. Generate some new parts of the map, so that it's not getting instantly overwritten later on
  3. Stop the server, delete the world and generate a new one
  4. Once you join the server again, journeymap will start overwrite the new chunks on your map, try to delete the map via gui and the error should occur

client logs:

latest.log
debug.log
journeymap.log

server logs:

latest.log

@xxhaze
Copy link
Author

xxhaze commented Jan 17, 2025

You can delete the map by deleting minecraft/journeymap/data/(mp or sp)/worldname/DIM*

And btw, deleting map from in-game GUI works for me.

using the latest release 0.2.4a modlist

Mhm that is weird? I reproduced the steps with the same version as you use journeymap-1.12.2-5.7.1p2 but doesn't seem to matter if I use journeymap-1.12.2-5.7.1p2 or journeymap-1.12.2-5.7.1p3 the error still occurs.

@kappa-maintainer
Copy link
Collaborator

Try the latest action build
I have tested it locally, and it seems both deleting through GUI and file worked

@xxhaze
Copy link
Author

xxhaze commented Jan 17, 2025

Try the latest action build I have tested it locally, and it seems both deleting through GUI and file worked

I tried it with the latest action build, still occurs by me. It deletes sometimes the newly generated map (everything around it, doesn't seem to be affected by the deletion) I hope the picture is understandable, as you can see, everything around the spawning point won't be deleted.

latest.log

journeymap.log

Image

@kappa-maintainer
Copy link
Collaborator

Post journeymap.log then

@xxhaze
Copy link
Author

xxhaze commented Jan 17, 2025

Post journeymap.log then

Sorry, it's updated now, forgot to attach it.

@kappa-maintainer
Copy link
Collaborator

Aha, so my patch did apply
Check latest action again

@xxhaze
Copy link
Author

xxhaze commented Jan 17, 2025

Only the spawning area map is getting deleted, everything else isn't. I recorded my game, not sure if it will help you.

latest.log

journeymap.log

https://youtu.be/P54Q0WEdVBA?si=XLJ7iMNVBWeD95bp

@kappa-maintainer
Copy link
Collaborator

No need to record anything, the new journeymap.log is enough
It seems guava changed the whole logic, will switch to Mixin

@kappa-maintainer
Copy link
Collaborator

Latest build should work this time, I screwed up opcodes in previous build

@xxhaze
Copy link
Author

xxhaze commented Jan 18, 2025

Latest build should work this time, I screwed up opcodes in previous build

The error still occurs, the same as before, only the spawn point part of the map is getting deleted. Everything around is not affected by the deletion

latest.log

journeymap.log

@kappa-maintainer
Copy link
Collaborator

Nah, that's a brand-new error

[FileHandler] Could not delete using: cmd.exe /C RD /S /Q "C:\Users\jonas\AppData\Roaming\PrismLauncher\instances\Cleanroom-MMC-instance-0.2.4-alpha(1)\minecraft\journeymap\data\mp\Minecraft~Server\DIM0" : java.io.IOException: Cannot run program "cmd.exe /C RD /S /Q "C:\Users\jonas\AppData\Roaming\PrismLauncher\instances\Cleanroom-MMC-instance-0.2.4-alpha(1)\minecraft\journeymap\data\mp\Minecraft~Server\DIM0"": CreateProcess error=2, The system cannot find the file specified

Please try to run the command manually and check if the file exist

@xxhaze
Copy link
Author

xxhaze commented Jan 18, 2025

DIM0 exists and has map files in it.

DIM0.zip

@kappa-maintainer
Copy link
Collaborator

Further searching shows that's caused by cmd.exe not in PATH
I am on Linux so it used rm and worked

@xxhaze
Copy link
Author

xxhaze commented Jan 18, 2025

The command worked with cmd as well.

@kappa-maintainer
Copy link
Collaborator

The problem is the JVM can't find cmd.exe
Please try:

  • Switching to JVM with another vendor
  • Check if JM works on regular Forge
  • Check environment variable of JVM

@xxhaze
Copy link
Author

xxhaze commented Jan 18, 2025

I tried it now with OpenLogic 21.0.5+11

Cleanroom: 0.2.4-alpha, OpenLogic 21.0.5+11:

JVM: JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms12160m -Xmx12160m (no java arguments manually added)

Still the same error as before, could not delete with with cmd.

latest.log

debug.log

journeymap.log


Forge 1.12.2, OpenLogic 21.0.5+11:

JVM: JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms12160m -Xmx12160m (no java arguments manually added)

Works without any error.

latest.log

debug.log

journeymap.log


Cleanroom: 0.2.4-alpha, Adoptium 21.0.5+11-LTS:

JVM: JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms12160m -Xmx12160m

Still the same error as before, could not delete with with cmd.

latest.log

debug.log

journeymap.log


Forge 1.12.2, Adoptium 21.0.5+11-LTS:

JVM: JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms12160m -Xmx12160m (no java arguments manually added)

Works without any error.

latest.log

debug.log

journeymap.log

@kappa-maintainer
Copy link
Collaborator

Just noticed, why it was Minecraft~Server with a ~

@G1ll0u
Copy link

G1ll0u commented Jan 23, 2025

Oh yeah try renaming the server in multiplayer menu

@xxhaze
Copy link
Author

xxhaze commented Jan 24, 2025

Didn't fix it, the same error as before:

Could not delete using: cmd.exe /C RD /S /Q "C:\Users\jonas\AppData\Roaming\PrismLauncher\instances\Cleanroom-MMC-instance-0.2.4-alpha\minecraft\journeymap\data\mp\TEST\DIM0"

latest.log

debug.log

journeymap.log

@kappa-maintainer
Copy link
Collaborator

Try latest action fugue, I overwrote the delete method

@xxhaze
Copy link
Author

xxhaze commented Jan 26, 2025

I still can't delete the map with the gui, but I got a different error:

[JourneymapClient] Mapping halted in C:\Users\jonas\AppData\Roaming\PrismLauncher\instances\Cleanroom-MMC-instance-0.2.4-alpha\minecraft\journeymap\data\mp\TEST\DIM0

[RegionImageCache] Deleted image directory C:\Users\jonas\AppData\Roaming\PrismLauncher\instances\Cleanroom-MMC-instance-0.2.4-alpha\minecraft\journeymap\data\mp\TEST\DIM0: false

[RegionImageCache] Done deleting directories

latest.log

debug.log

journeymap.log

@kappa-maintainer
Copy link
Collaborator

Added more logging in latest commit

@xxhaze
Copy link
Author

xxhaze commented Jan 26, 2025

Here are the new logs:

latest.log

debug.log

journeymap.log

@kappa-maintainer
Copy link
Collaborator

Again with latest
Last commit was broken

@xxhaze
Copy link
Author

xxhaze commented Jan 26, 2025

The new ones:

latest.log

debug.log

journeymap.log

@kappa-maintainer
Copy link
Collaborator

So the file did exist, but failed to delete, wtf

@kappa-maintainer
Copy link
Collaborator

99% sure this time will work on your PC

@xxhaze
Copy link
Author

xxhaze commented Jan 28, 2025

It's fixed now, I can delete the map with the gui now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants