Unskip exit signal handling

ClearcodeHQ · May 20, 2021 · f7e2ec9 · f7e2ec9
1 parent 8c039b7
commit f7e2ec9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/tests/executors/test_executor.py b/tests/executors/test_executor.py
@@ -19,9 +19,6 @@
 SLEEP_300 = "sleep 300"
 
 
-@pytest.mark.skipif(
-    "platform.system() == 'Windows'", reason="Expects signal -15 gets 15"
-)
 @pytest.mark.parametrize("command", (SLEEP_300, SLEEP_300.split()))
 def test_running_process(command):
     """Start process and shuts it down."""
@@ -36,9 +33,6 @@ def test_running_process(command):
     assert SLEEP_300 in str(executor)
 
 
-@pytest.mark.skipif(
-    "platform.system() == 'Windows'", reason="Expects signal -15 gets 15"
-)
 @pytest.mark.parametrize("command", (SLEEP_300, SLEEP_300.split()))
 def test_command(command):
     """Check that the command and command parts are equivalent."""

diff --git a/tests/executors/test_executor_kill.py b/tests/executors/test_executor_kill.py
@@ -91,7 +91,10 @@ def test_daemons_killing():
 
 @pytest.mark.skipif(
     "platform.system() == 'Windows'",
-    reason="Expects signal -15 gets 15 at the last stop",
+    reason=(
+        "Subprocess killed earlier than in 10 secs. "
+        "Blocking signals probably doesn't work."
+    ),
 )
 def test_stopping_brutally():
     """