You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On GitLab enterprise, mp merge currently merges if it is possible to merge. If a repo is not configured with any merge rules requiring an approval, this means merges will occur potentially with no review. I would like the option to merge only if an explicit approval was given by a reviewer regardless of how the project is configured.
In addition, mp status should independently report the approval status of a pending MR.
The text was updated successfully, but these errors were encountered:
If approvals_left > 0 that implies the MR is missing approvals and we can signal that in mp status output. If approvals_left == 0 but len(approved_by) > 0 that implies an explicit approval was given and we can merge even when --require-approval. GitLab projects may have complex approval rules, though, and I don't know how best to handle that.
On GitLab enterprise,
mp merge
currently merges if it is possible to merge. If a repo is not configured with any merge rules requiring an approval, this means merges will occur potentially with no review. I would like the option to merge only if an explicit approval was given by a reviewer regardless of how the project is configured.In addition,
mp status
should independently report the approval status of a pending MR.The text was updated successfully, but these errors were encountered: