Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle nested repos in init for GitLab #251

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

lucas-zmroczek-apl
Copy link
Contributor

@lucas-zmroczek-apl lucas-zmroczek-apl commented Mar 29, 2024

#93 1

Overview

This change allows for tested GitLab repos to be initialized. An example repos.txt file:

myorg/repo1
myorg/groupA/repo2
myorg/groupA/repo3
myorg/groupB/repo4

Before the fix, only myorg/repo1 would initialize. After the fix, all repos initialize.

Testing

Tested on GitLab, by running mp init with a repos file that contained the nested repos, as described in the example above.

# Before the fix
$ mp init --provider=gitlab --provider-url=https://gitlab.myorg.edu/ -f repos.txt
2024/03/29 16:53:01 unable determine repo from line, expected format '{org}/{repo}': myorg/groupA/repo2

# After the fix
$ ./src/microplane/bin/mp init --provider=gitlab --provider-url=https://gitlab.myorg.edu/ -f repos.txt
myorg/repo1
myorg/groupA/repo2
myorg/groupA/repo3
myorg/groupB/repo4

Footnotes

  1. https://clever.atlassian.net/browse/INFRANG-6565

@lucas-zmroczek-apl lucas-zmroczek-apl requested a review from a team as a code owner March 29, 2024 20:56
@lucas-zmroczek-apl lucas-zmroczek-apl requested review from jakegut and removed request for a team March 29, 2024 20:56
@lucas-zmroczek-apl
Copy link
Contributor Author

I'm not sure how to set the JIRA ticket, but this addresses the GitHub issue #93

@jakegut
Copy link
Contributor

jakegut commented Oct 25, 2024

@lucas-zmroczek-apl Could you look into the build errors and fix them? Seems like there's an API change and I don't want to break anything GitLab related

@jakegut
Copy link
Contributor

jakegut commented Oct 28, 2024

LGTM, just bump the version by a patch number in VERSION and I can merge it

@jakegut
Copy link
Contributor

jakegut commented Oct 30, 2024

Awesome, thanks for your contribution! Sorry it took so long to get to.

@jakegut jakegut merged commit ea52773 into Clever:master Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants