Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensions support #1

Open
c-b-h opened this issue Jun 25, 2019 · 1 comment
Open

Dimensions support #1

c-b-h opened this issue Jun 25, 2019 · 1 comment

Comments

@c-b-h
Copy link

c-b-h commented Jun 25, 2019

Are you planning to introduce support for dimensions?

We have a project with three dimensions with each having at least 2 variants meaning that we need to define 6-10 productFlavors entries alternatively variants entries when all we want is to say that all variants with a particular dimension entry should have badge.

@c-b-h
Copy link
Author

c-b-h commented Jun 25, 2019

android {
   flavorDimensions "brand", "environment", "audience"
    buildTypes {
        debug {}
        release {}
    }
    productFlavors {
        stage { dimension "environment" }
        production { dimension "environment" }

        company1 { dimension "brand" }
        company2 { dimension "brand" }
        company3 { dimension "brand" }

        internal { dimension "audience" }
        external { dimension "audience" }
    }
}

We would love to be able to write:

badge {
    productFlavors {
        internal {
            enabled = true
            text = "Version 1.0.1 (65)"
            textColor = "#000000"
            labelColor = "#FFFFFF"
        }

        external {
            enabled = true
            text = "Version 1.0.1 (65)"
            textColor = "#FFFFFF"
            labelColor = "#000000"
        }
    }
}

But as AppBadgePlugin.getVariantExtensions only iterates through flavorName, only concatenated productFlavors will be accepted as valid, e.g. stageCompany2External.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant