Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix longitude_name call in apply_latlon_mask #195

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

juliasloan25
Copy link
Member

Purpose

closes #191

The test I added fails without the change in src, and passes with it

@juliasloan25 juliasloan25 changed the title fix longitude_name call in latlon masking fix longitude_name call in apply_latlon_mask Feb 13, 2025
@juliasloan25 juliasloan25 requested review from Sbozzolo and ph-kev and removed request for Sbozzolo February 13, 2025 00:44
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (28823aa) to head (6ad7d5e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          12       12           
  Lines        1209     1209           
=======================================
  Hits         1187     1187           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@juliasloan25 juliasloan25 merged commit 758cfe0 into main Feb 13, 2025
9 checks passed
@juliasloan25 juliasloan25 deleted the js/input-var-name branch February 13, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_latlon_mask fails if longitude not named "lon"
2 participants